From: Joel Stanley <joel@jms.id.au>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [PATCH 2/3] Arm: dts: aspeed-g6: Add sgpio node
Date: Wed, 28 Oct 2020 05:10:49 +0000 [thread overview]
Message-ID: <CACPK8Xeg_LRGv1EEm7cdDWK2xST0mBP=iG7=43UE5qmEMMDsHQ@mail.gmail.com> (raw)
In-Reply-To: <E0B8BD13-86F6-486E-95DF-1038D7F59A8B@aspeedtech.com>
On Mon, 12 Oct 2020 at 04:56, Billy Tsai <billy_tsai@aspeedtech.com> wrote:
>
> Hi Joel,
>
> Thanks for the review.
>
> On 2020/10/12, 12:35 PM, Joel Stanley wrote:
>
> > On Mon, 12 Oct 2020 at 03:32, Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> > >
> > > This patch is used to add sgpiom and sgpios nodes and add compatible
> > > string for sgpiom.
> >
> > You also need to add sgpios documentation to the bindings docs.
> >
> > Whenever you add new device tree bindings to the kernel tree you
> > should add documentation for them.
> >
> > When preparing patches for submission, use scripts/checkpatch.pl to
> > check for common issues. It will warn you if you are adding strings
> > that are not documented.
> >
> > Cheers,
> >
> > Joel
> >
> Because the driver of sgpios doesn't be implemented, so I don't know how to describe it at sgpio-aspeed.txt.
> Can I just add compatible string " aspeed,ast2600-sgpios " to the document for bypassing the warning of checkpatch?
Ignore the sgpios issue for now; we don't have a driver for it so
there's no need to add strings. Drop that part from your dts patch.
> > >
> > > - compatible : Should be one of
> > > - "aspeed,ast2400-sgpio", "aspeed,ast2500-sgpio"
> > > + "aspeed,ast2400-sgpio", "aspeed,ast2500-sgpio", "aspeed,ast2600-sgpiom"
> >
> > I think we should add sgpiom strings for the ast2500 (and ast2400?)
> > too, as this is how they should have been named in the first place:
> >
> If I change the document whether I also need to send the patch for sgpio driver and g5/g4.dtsi?
For the sgpiom? We already have a driver for that.
As I said above, make this about fixing the sgpio master and put aside
the sgpio slave issue for now.
Cheers,
Joel
> > > - compatible : Should be one of
> > > "aspeed,ast2400-sgpio", "aspeed,ast2500-sgpio"
> > > "aspeed,ast2400-sgpiom", "aspeed,ast2500-sgpiom", "aspeed,ast2600-sgpiom"
next prev parent reply other threads:[~2020-10-28 23:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 3:31 [V2 PATCH 0/3] Fix the memory layout and add sgpio node for aspeed g6 Billy Tsai
2020-10-12 3:31 ` [PATCH 1/3] Arm: dts: aspeed-g6: Fix the register range of gpio Billy Tsai
2020-10-12 4:30 ` Joel Stanley
2020-10-26 1:05 ` Andrew Jeffery
2020-10-28 5:12 ` Joel Stanley
2020-10-12 3:31 ` [PATCH 2/3] Arm: dts: aspeed-g6: Add sgpio node Billy Tsai
2020-10-12 4:35 ` Joel Stanley
2020-10-12 4:53 ` Billy Tsai
2020-10-28 5:10 ` Joel Stanley [this message]
2020-10-26 1:33 ` Andrew Jeffery
2020-10-12 3:31 ` [PATCH 3/3] pinctrl: aspeed-g6: Add sgpiom2 pinctrl setting Billy Tsai
2020-10-12 4:36 ` Joel Stanley
2020-10-26 1:26 ` Andrew Jeffery
2020-10-26 2:03 ` Billy Tsai
2020-10-26 2:20 ` Andrew Jeffery
2020-10-26 2:56 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8Xeg_LRGv1EEm7cdDWK2xST0mBP=iG7=43UE5qmEMMDsHQ@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=bgolaszewski@baylibre.com \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).