From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03D0C4363A for ; Wed, 28 Oct 2020 23:42:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3146D207E8 for ; Wed, 28 Oct 2020 23:42:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="OC6Zm4U5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726145AbgJ1XmV (ORCPT ); Wed, 28 Oct 2020 19:42:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbgJ1XmI (ORCPT ); Wed, 28 Oct 2020 19:42:08 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80296C0613CF; Wed, 28 Oct 2020 16:42:08 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id h12so791397qtc.9; Wed, 28 Oct 2020 16:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=04ThpYsSViFhWqOQvQSGIlYZRGcXGFtIhUlX8pfHTD8=; b=OC6Zm4U5t2xQjcut4yBwkeEk5KarEkjfCrPdUlu381Nv4vJI895Svp7x8sDb3IBxS3 fPfhT1B7HGC5UpOKgQPbPKJ8OQ+Wh5ei1AjIXfyGnvpaGsc8RYdCba4m2e8dSOSNKG0r 6IaEkkFLl4zzAivCnLsMl8DdDeZ7xDzu5G81g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=04ThpYsSViFhWqOQvQSGIlYZRGcXGFtIhUlX8pfHTD8=; b=DLMle3rBT5FB64Jk9Cu8f3eYwMY/3daZc7z+O2hNNbwt5pFquzv7nLowGJY4uNv0mj uKcBG+PN5LFZZs7P+mUs34LQg5zJWR/oLVa9t2vrARLE2fjdrzL3Ij8qUs3dhSU0QO6y +4w0I6BQOW7CInLVoEzrzDyL3oC4xg++q/Hg6QWSU5LYfQLRCIGNX6gAYmuIY2JeHpOh hbi1xa1vMnyNz6L5bCUzZ3k1+tz/QQOXXZGGsaym8W56q7asN+U8fjaU9T3OiC238qr5 B+P/3RgZAVkkfiwH9M2aLqz8O/+3nScpD31x78+BKGDUOi9BddixEVME8i1VrIOBFgYl nJtQ== X-Gm-Message-State: AOAM5300wHRy/OUwaVJZqGthLvjrALd7PddJlhopgrvW/ozb65VqlMum I6R+hxE++nacojzzX1wzL4GZ5uBfyI2GR19WswbUdjtlX2xVCg== X-Google-Smtp-Source: ABdhPJyi2tYbl11+8oD/pTg7MqvJo0FJxH9J/m9YOi24yaf3RoUaPY8LWOMrUDpfxRRNH1Z9ZM9QvQ/K9quBWlRWBR8= X-Received: by 2002:a05:620a:1303:: with SMTP id o3mr5853719qkj.66.1603861861220; Tue, 27 Oct 2020 22:11:01 -0700 (PDT) MIME-Version: 1.0 References: <20201012033150.21056-1-billy_tsai@aspeedtech.com> <20201012033150.21056-3-billy_tsai@aspeedtech.com> In-Reply-To: From: Joel Stanley Date: Wed, 28 Oct 2020 05:10:49 +0000 Message-ID: Subject: Re: [PATCH 2/3] Arm: dts: aspeed-g6: Add sgpio node To: Billy Tsai Cc: Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , Linus Walleij , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , OpenBMC Maillist , BMC-SW Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 12 Oct 2020 at 04:56, Billy Tsai wrote: > > Hi Joel, > > Thanks for the review. > > On 2020/10/12, 12:35 PM, Joel Stanley wrote: > > > On Mon, 12 Oct 2020 at 03:32, Billy Tsai wrote: > > > > > > This patch is used to add sgpiom and sgpios nodes and add compatible > > > string for sgpiom. > > > > You also need to add sgpios documentation to the bindings docs. > > > > Whenever you add new device tree bindings to the kernel tree you > > should add documentation for them. > > > > When preparing patches for submission, use scripts/checkpatch.pl to > > check for common issues. It will warn you if you are adding strings > > that are not documented. > > > > Cheers, > > > > Joel > > > Because the driver of sgpios doesn't be implemented, so I don't know how to describe it at sgpio-aspeed.txt. > Can I just add compatible string " aspeed,ast2600-sgpios " to the document for bypassing the warning of checkpatch? Ignore the sgpios issue for now; we don't have a driver for it so there's no need to add strings. Drop that part from your dts patch. > > > > > > - compatible : Should be one of > > > - "aspeed,ast2400-sgpio", "aspeed,ast2500-sgpio" > > > + "aspeed,ast2400-sgpio", "aspeed,ast2500-sgpio", "aspeed,ast2600-sgpiom" > > > > I think we should add sgpiom strings for the ast2500 (and ast2400?) > > too, as this is how they should have been named in the first place: > > > If I change the document whether I also need to send the patch for sgpio driver and g5/g4.dtsi? For the sgpiom? We already have a driver for that. As I said above, make this about fixing the sgpio master and put aside the sgpio slave issue for now. Cheers, Joel > > > - compatible : Should be one of > > > "aspeed,ast2400-sgpio", "aspeed,ast2500-sgpio" > > > "aspeed,ast2400-sgpiom", "aspeed,ast2500-sgpiom", "aspeed,ast2600-sgpiom"