From: Joel Stanley <joel@jms.id.au>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-aspeed@lists.ozlabs.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org, Andrew Jeffery <andrew@aj.id.au>,
Rob Herring <robh+dt@kernel.org>, Sean Paul <sean@poorly.run>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] drm: Add ASPEED GFX driver
Date: Wed, 3 Apr 2019 00:14:43 +0000 [thread overview]
Message-ID: <CACPK8XfGD5FVWXAvnFJ2eReDH_ebvv2Z4NfoQiGaLXd6b30nWQ@mail.gmail.com> (raw)
In-Reply-To: <20190402062555.GA14723@ravnborg.org>
On Tue, 2 Apr 2019 at 06:26, Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Joel
>
> > index 000000000000..fb56e425bd48
> > --- /dev/null
> > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h
> > @@ -0,0 +1,104 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +// Copyright 2018 IBM Corporation
> > +
> > +#include <drm/drmP.h>
> > +#include <drm/drm_simple_kms_helper.h>
>
> A drmP.h include was left here, can we have this removed too.
>
> > +
> > +static struct drm_driver aspeed_gfx_driver = {
> > + .driver_features = DRIVER_GEM | DRIVER_MODESET |
> > + DRIVER_PRIME | DRIVER_ATOMIC |
> > + DRIVER_HAVE_IRQ,
> DRIVER_HAVE_IRQ is obsolete and not needed anymore.
> See drm_drv.h for details.
>
> With these few things fixed:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thanks for the review. I've fixed those up now, and this time I'm sure
there's no drmP.h!
Cheers,
Joe
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-03 0:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 2:19 [PATCH v2 0/3] drm: Add ASPEED BMC 'GFX' driver Joel Stanley
2019-04-02 2:19 ` [PATCH v2 1/3] dt-bindings: gpu: Add ASPEED GFX bindings document Joel Stanley
2019-04-02 3:08 ` Andrew Jeffery
2019-04-02 2:19 ` [PATCH v2 2/3] drm: Add ASPEED GFX driver Joel Stanley
2019-04-02 6:25 ` Sam Ravnborg
2019-04-03 0:14 ` Joel Stanley [this message]
2019-04-02 2:19 ` [PATCH v2 3/3] MAINTAINERS: Add ASPEED BMC GFX DRM driver entry Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8XfGD5FVWXAvnFJ2eReDH_ebvv2Z4NfoQiGaLXd6b30nWQ@mail.gmail.com \
--to=joel@jms.id.au \
--cc=airlied@linux.ie \
--cc=andrew@aj.id.au \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).