From: Linus Walleij <linus.walleij@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] gpio: mcp23s08: Add option to configure pullups.
Date: Mon, 24 Oct 2016 02:53:31 +0200 [thread overview]
Message-ID: <CACRpkdY15Hv_ydHyOXRM6G0ewVTHkVa1w3Z89AdvSDR=eyi7sQ@mail.gmail.com> (raw)
In-Reply-To: <1477062035-30825-1-git-send-email-enric.balletbo@collabora.com>
On Fri, Oct 21, 2016 at 5:00 PM, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
> Default is without pullups, but if property is specified in DT and the bit
> is set, set a pullup on GPIO-n.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
I don't generally like this.
In device tree it is the consumer that specifies how the line is used,
not the producer (gpiochip).
We currently only specify polarity, open drain and open source
for consumers though.
And the entire pin control system came into being *exactly* because
Grant didn't like me adding these things to the GPIO drivers.
So how many other things does the MCP support? Drive strength?
Schmitt trigger? Is there a datasheet?
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-10-24 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 15:00 [PATCH] gpio: mcp23s08: Add option to configure pullups Enric Balletbo i Serra
2016-10-24 0:53 ` Linus Walleij [this message]
2016-10-24 6:13 ` Alexander Stein
2016-10-26 9:59 ` Enric Balletbo Serra
2016-10-27 12:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY15Hv_ydHyOXRM6G0ewVTHkVa1w3Z89AdvSDR=eyi7sQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).