From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 04/14] mmc: mmci: Add STM32 variant Date: Tue, 16 Jan 2018 08:38:33 +0100 Message-ID: References: <1515759368-16946-1-git-send-email-patrice.chotard@st.com> <1515759368-16946-5-git-send-email-patrice.chotard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Patrice CHOTARD Cc: Russell King , Ulf Hansson , Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Alexandre TORGUE , linux-mmc , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-clk , Linux ARM , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Andrea Merello List-Id: devicetree@vger.kernel.org On Mon, Jan 15, 2018 at 6:17 PM, Patrice CHOTARD wrote: >>> + { >>> + .id = 0x00880180, >>> + .mask = 0x00ffffff, >>> + .data = &variant_stm32, >>> + }, >> >> Since ux500 was 480180 I wonder what variants 5,6,7 are... > > What is the rule to define the id ? These four bits mean "revision". The number comes from hardware, so the ST ASIC department has some person who is responsible for revising the VHDL or Verilog code that this hardware is compiled from, and that person is bumping the version. Theoretically it is a "company function" or something bureaucratic like that updating the hardware so I guess it could be several people following procedure who have updated this number in the hardware over the years. But I bet it is a single person in Grenoble who has been doing the MMC/SD block since it appeared. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html