From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Andreas Larson <andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
Cc: software-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Anton Vorontsov
<anton.vorontsov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v5 2/3] gpio: grgpio: Add device driver for GRGPIO cores
Date: Tue, 23 Apr 2013 13:09:28 +0200 [thread overview]
Message-ID: <CACRpkdYDBuXcPDzkpL2DeaWYBXJM78cUNQkw3Uga1MyGobMayw@mail.gmail.com> (raw)
In-Reply-To: <516BF4D2.8060901-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
On Mon, Apr 15, 2013 at 2:38 PM, Andreas Larson <andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org> wrote:
> On 2013-04-10 20:50, Linus Walleij wrote:
>>> +Required properties:
>>> +
>>> +- name : Should be "GAISLER_GPIO" or "01_01a"
>>
>> What is this? Don't we usually use a .compatible string for this?
>> Name? Que? Is that something legacy?
>
> Regarding using name, this is standard for SPARC. The names in the
> device tree originates from the PROM.
>
> The name field is the actually the first field checked for a match in
> of_match_node, followed by type then compatible. See
> http://lxr.free-electrons.com/source/drivers/of/base.c#L572
>
(...)
> As for the "01_01a", the LEON SPARC systems uses a plug&play to identify
> different IP cores in the system. When the PROM is unaware of the name
> of a certain core, the name field presented from the prom will be on
> this form. This is standard handling for LEON SPARC drivers.
Thanks for detailing this! There is such a big world out there sometimes.
I'm sort of wondering why we do things the way we do in the ARM DT
world sometimes. Specifically I suspect that we should be using
name or type rather than compatible for the ARM PrimeCells, which
are a sort of plug-n-play type devices, but I guess it's too late
to change that now...
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-04-23 11:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 13:45 [PATCH v5 0/3] gpio: Add device driver for GRGPIO cores and support custom accessors with gpio-generic Andreas Larsson
2013-03-15 13:45 ` [PATCH v5 1/3] gpio: gpio-generic: Add 16 and 32 bit big endian byte order support Andreas Larsson
2013-03-19 0:40 ` Anton Vorontsov
[not found] ` <20130319004012.GA1004-1CZZkhFgUWNRmOO2HpYVOJIbA5emDH3N@public.gmane.org>
2013-03-27 8:58 ` Linus Walleij
2013-04-03 7:49 ` Andreas Larson
2013-04-10 18:27 ` Linus Walleij
2013-03-15 13:45 ` [PATCH v5 2/3] gpio: grgpio: Add device driver for GRGPIO cores Andreas Larsson
2013-04-10 18:50 ` Linus Walleij
2013-04-15 12:38 ` Andreas Larson
[not found] ` <516BF4D2.8060901-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
2013-04-23 11:09 ` Linus Walleij [this message]
2013-03-15 13:45 ` [PATCH v5 3/3] gpio: grgpio: Add irq support Andreas Larsson
2013-04-10 19:25 ` Linus Walleij
2013-04-15 12:38 ` Andreas Larson
2013-04-23 11:14 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYDBuXcPDzkpL2DeaWYBXJM78cUNQkw3Uga1MyGobMayw@mail.gmail.com \
--to=linus.walleij-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org \
--cc=anton.vorontsov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=software-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).