From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] iio: dac: ds4422/ds4424 dac driver Date: Fri, 15 Sep 2017 09:11:31 +0200 Message-ID: References: <20170914202449.31283-1-Ismail.Kose@maximintegrated.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170914202449.31283-1-Ismail.Kose-zxKO94PEStzToO697jQleEEOCMrvLtNR@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ismail Kose Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Rob Herring , Mark Rutland , William Breathitt Gray , Jean-Francois Dagenais , Fabrice Gasnier , gwenhael.goavec-merou-W7CSdorvuhNZroRs9YW3xA@public.gmane.org, Peter Rosin , =?UTF-8?Q?Maxime_Roussin=2DB=C3=A9langer?= , Mike Looijmans , "Ismail H. KOSE" , "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Thu, Sep 14, 2017 at 10:24 PM, Ismail Kose wrote: > +struct ds4424_pdata { > + const char *vcc_supply_name; Should not be needed at all, get the supply directly from the device tree. > + uint32_t rfs_res[DS4424_MAX_DAC_CHANNELS]; > + struct iio_map *dac_iio_map; > +}; Drop this entire platform data file and move all these fields you still need into struct ds4424_data. If you have legacy kernels still using platform data, that's too bad, we will not maintain them upstream and not merge new board files using platform data normally, use device tree or ACPI DSTD only please. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html