From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52D0F3314DF for ; Mon, 27 Oct 2025 22:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761604954; cv=none; b=q4M176xVBp2J3jTDEj6QcZOs/lnwqh7rFgRVfReloMfW85w3CG3dI9iNpwebz68/He0aoKtReh69mFpMw2rMCCtTspKmtQEioP+a5K+hXgz/QsM9rWyuZXrX2TDk+AR633zIH2vtVvpHc0ol2XYrz36s6TGQC3DW9F6maW8qX5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761604954; c=relaxed/simple; bh=mdMs/b0H8ZKYdk7N+cLM+Uj/aE/vejpLNMBlaSFUExo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=PKOXYYX4mMq3VmmC6TNttCXzp66Fe+ktBgiekGvWVGJDoivJVqn+7OmEYU/mNYmJ9k/b2Q31ks8KZGlVuEMWkLfpBLtetE7oaFSGIDYD5i95SrNRYsZlUHi4vK8514rvY2EbQJ6mYtWwpmvOfeNdtYAbMJ3UuYxJr2aDnfBHUwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KZZdxYt0; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KZZdxYt0" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-78619d34979so2767957b3.2 for ; Mon, 27 Oct 2025 15:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761604951; x=1762209751; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FEbWuq+sA3qayyKc6Q0Zwp+mZTGvAg5r2iKjERsSY7s=; b=KZZdxYt0Z2WZKZuPgT5rRan52bxSrRh4T492YeoJIxeDY4LeXNDR+R3yOnRnZyzVb8 KBlWPmFy+95MRsIPWWq05i/z4Vn8LC7vRp0/hibWv4bpyEPuRJpN8p04JKGNALA59BXB r3b3PPsDTPdzYTJGjWqbufP1y7+F4e3Z/hYN3mc3SqLZRCp6/byeKiquedgj54rR/WoW zQl9+qIucwctk7wZ2brLUUZ0eQi/1r9U9SISaTDla8dXL6QC8+0YkkCn12F12/lVVHm5 EdDcsB2o5zlBZs5CEApaknmyKahuQv4I3nfHGGpBcs/xheH7rog0kOa5jFGtyALH4ZMW qI4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761604951; x=1762209751; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FEbWuq+sA3qayyKc6Q0Zwp+mZTGvAg5r2iKjERsSY7s=; b=mR5pQH3z85UUSzOX8McujzSs/wQ/maoqFih9PUE4KMZcmraU1IzDQcoxifgnf1UJWK Db6E1V0zSjgo3LhVrKd0iXRfmHT8yGT4UQNulu+bmmWPcfax+H1k6MYRX/ooqJtf9D9r z1DCfdzQbZddQ9TMEsCE/DCq5WzmRQI/Y67ib+buTigZdKpJZKkI6BdZGCK9uhKFTHGY Cv684ciGlCZLpvLAt0/mwn0g99rLm0uVCqU0g96Z/gH3gTTmSzCiqgggcLdDaZL5QepW wq+QEBKMLTmk7BrJTW99m/tw+dmxoQ8Q9sx8MpdcQOLBBfxN4KjbNHbDNrcl+/k0V8K3 p4Aw== X-Forwarded-Encrypted: i=1; AJvYcCWc8R9bcmYS7TWJtAqZUW/TbpNtmNLwzmKNse+24mfRC20Hrv7bHROV33bsJup/dNds90mATpiSujMN@vger.kernel.org X-Gm-Message-State: AOJu0YxgZ5QGSxx++68us1ctgY0zMtHVZONtjkr/u5mZJH7hAh7limOO lOc6gdH99cTGcX9eg4kZSkmdRMXO8c9fZMnvpg0rn8W/AGZ6h1z58DFMCakMFYEn1wNdFaP2MQG mi33/lQArELWNqyjsPVWuLiI4VsBo8KPqj/DhotpQUw== X-Gm-Gg: ASbGncuaTgfCMDMyCUMA9IXHcSLKqsH482fAneUub6tq4ZgSD7eyA941mMSmQPQltqz 1NQ7PZ7kqtZ4RojxFvPzzGTcqqINWK7+psdYLczSG+FjOwv1W0/+N113eGEdHIln1Q74E4rynyO DKuhTRrek7JfYtQMHbBQAbttSYz0x9VXjfhMsTnawC/E8+4kymRxNDMjlkVj9O7TEmMqsrpPeS9 k5/l5H9pny7fJT1aG4TN+adLlfFHsxqE03aRaiHAACcXCNn8xZTrWcBfxZH X-Google-Smtp-Source: AGHT+IFea0a7SdSezzmFvdSfx4jiKtpkMteXYqF7MqSlxI3OsRPCoABiY/0t3pyhk2zywEU29O2vl188K3Ur1ROhIiE= X-Received: by 2002:a05:690c:3684:b0:783:697a:5daa with SMTP id 00721157ae682-78617ed7dc7mr16221547b3.30.1761604951123; Mon, 27 Oct 2025 15:42:31 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Mon, 27 Oct 2025 23:42:18 +0100 X-Gm-Features: AWmQ_bnqjdOEx6PHBZRMUEpMuG3EOvSnhd1cnxA8WMLK3e2WMcsLHGdno_I3fzM Message-ID: Subject: Re: [PATCH v2 04/15] dt-bindings: mfd: ROHM BD72720 To: Matti Vaittinen Cc: Matti Vaittinen , Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Bartosz Golaszewski , Andreas Kemnade , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Matti, thanks for your patch! On Mon, Oct 27, 2025 at 12:45=E2=80=AFPM Matti Vaittinen wrote: > + rohm,clkout-open-drain: > + description: clk32kout mode. Set to 1 for "open-drain" or 0 for "cmo= s". > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 1 I think CMOS is the same as "push-pull" ( I could be wrong, but I think I'v= e seen that before) so I would probably try to use the pin config standard names as strings here but I'm not sure. rohm,clkout-bias-open-drain; rohm,clkout-bias-push-pull; Mutually exclusive. Or maybe use the pattern from rohm,pin-dvs0 with string enumerators? rohm,clkout-bias =3D "open-drain"; rohm,clkout-bias =3D "push-pull"; ? > +examples: Maybe add some of the exotic string options into the example so people will get it right? Yours, Linus Walleij