From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 1/3] gpio: syscon: Add support for a custom get operation Date: Thu, 12 Sep 2019 10:18:34 +0100 Message-ID: References: <20190910152855.111588-1-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190910152855.111588-1-paul.kocialkowski@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org To: Paul Kocialkowski Cc: "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , Rob Herring , Mark Rutland , Thomas Petazzoni List-Id: devicetree@vger.kernel.org On Tue, Sep 10, 2019 at 4:29 PM Paul Kocialkowski wrote: > Some drivers might need a custom get operation to match custom > behavior implemented in the set operation. > > Add plumbing for supporting that. > > Signed-off-by: Paul Kocialkowski Looks OK but as noted in the other patch: we are accumulating stuff in this driver, possibly this syscon part should just be a library used by individual drivers that can be switched on/off with Kconfig. Yours, Linus Walleij