devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Rob Herring <robh@kernel.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Jassi Brar <jaswinder.singh@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO binding
Date: Wed, 27 Sep 2017 15:42:05 +0200	[thread overview]
Message-ID: <CACRpkdYJSXH+94QScrpSPdfy8ULa6dV2q0qRjsfKAAWSRuKTKQ@mail.gmail.com> (raw)
In-Reply-To: <1506480343-9597-2-git-send-email-yamada.masahiro@socionext.com>

On Wed, Sep 27, 2017 at 4:45 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> This GPIO controller is used on UniPhier SoC family.
>
> The vendor specific property "socionext,interrupt-ranges" is for
> specifying interrupt mapping to the parent interrupt controller
> because the mapping is not contiguous.  It works like "ranges",
> but transforms "interrupts" instead of "reg".
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Rob Herring <robh@kernel.org>

I don't think Rob has seen the new interrupt range thing?
(It's not a big deal. Things like these are a bit fuzzy.)

> +               socionext,interrupt-ranges = <0 48 16>, <16 154 5>, <21 217 3>;

If it is as you say, that other SoCs are doing the same, we should
think about creating a generic property for this. Like
hierarchy-interrupt-ranges or so.

I kind of liked the old patch where it was just "interrupts" and
then you looked it up from the irq subsystem. (tglx even ACKed
the patch).

But I want the DT people to say something here.

Yours,
Linus Walleij

  reply	other threads:[~2017-09-27 13:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-27  2:45 [PATCH v7 0/2] gpio: uniphier: UniPhier GPIO driver Masahiro Yamada
     [not found] ` <1506480343-9597-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2017-09-27  2:45   ` [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO binding Masahiro Yamada
2017-09-27 13:42     ` Linus Walleij [this message]
2017-09-27 14:42       ` Masahiro Yamada
     [not found]       ` <CACRpkdYJSXH+94QScrpSPdfy8ULa6dV2q0qRjsfKAAWSRuKTKQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-08 13:42         ` Masahiro Yamada
2017-09-27  2:45 ` [PATCH v7 2/2] gpio: uniphier: add UniPhier GPIO controller driver Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdYJSXH+94QScrpSPdfy8ULa6dV2q0qRjsfKAAWSRuKTKQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).