devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Daniel Palmer <daniel@0x0f.com>,
	DTML <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Romain Perier <romain.perier@gmail.com>
Subject: Re: [PATCH 2/3] irqchip: SigmaStar SSD20xD gpi
Date: Tue, 21 Sep 2021 20:23:04 +0200	[thread overview]
Message-ID: <CACRpkdYLURJCopH3hDuZTY8ce9-OxakELyFqwqkAVCsYmzF5kg@mail.gmail.com> (raw)
In-Reply-To: <87lf3quydn.wl-maz@kernel.org>

On Tue, Sep 21, 2021 at 10:27 AM Marc Zyngier <maz@kernel.org> wrote:

> Linus: is there a reason why the gpiolib insist on setting its own
> handler while building the hierarchy?

Is it this?

        /*
         * We set handle_bad_irq because the .set_type() should
         * always be invoked and set the right type of handler.
         */
        irq_domain_set_info(d,
                            irq,
                            hwirq,
                            gc->irq.chip,
                            gc,
                            girq->handler,
                            NULL, NULL);
        irq_set_probe(irq);
(...)

IIUC it's because sometimes, on elder systems (such as ixp4xx) some machines
are still using boardfiles, and drivers are not obtaining IRQs dynamically
from device tree or ACPI, instead they are set up statically at machine
init.

I assume it would otherwise be done as part of ops->translate?

I suppose it could be solved with a patch that take this route only if
we're not using device tree or ACPI?

If this is the totally wrong answer then forgive me... a bit tired.

Yours,
Linus Walleij

  reply	other threads:[~2021-09-21 18:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 10:04 [PATCH 0/3] SigmaStar SSD20XD GPIO interrupt controller Daniel Palmer
2021-09-14 10:04 ` [PATCH 1/3] dt-bindings: interrupt-controller: Add SigmaStar SSD20xD gpi Daniel Palmer
2021-09-21 20:36   ` Rob Herring
2021-09-14 10:04 ` [PATCH 2/3] irqchip: " Daniel Palmer
2021-09-20  9:45   ` Marc Zyngier
2021-09-20 10:05     ` Daniel Palmer
2021-09-20 11:24       ` Marc Zyngier
2021-09-21  4:16         ` Daniel Palmer
2021-09-21  8:27           ` Marc Zyngier
2021-09-21 18:23             ` Linus Walleij [this message]
2021-09-30 12:39               ` Daniel Palmer
2021-09-30 13:07                 ` Marc Zyngier
2021-09-30 13:10                   ` Daniel Palmer
2021-09-30 13:06               ` Marc Zyngier
2021-09-30 13:36                 ` Daniel Palmer
2021-09-30 13:53                   ` Marc Zyngier
2021-09-30 13:59                     ` Daniel Palmer
2021-09-30 14:11                       ` Marc Zyngier
2021-09-30 16:10                         ` Linus Walleij
2021-09-30 16:13                   ` Linus Walleij
2021-10-01 12:33                     ` Daniel Palmer
2021-10-02  3:08                     ` Daniel Palmer
2021-09-21  6:11         ` Daniel Palmer
2021-09-14 10:04 ` [PATCH 3/3] ARM: dts: mstar: Add gpi interrupt controller to i2m Daniel Palmer
2021-09-14 15:59 ` [PATCH 0/3] SigmaStar SSD20XD GPIO interrupt controller Andrew Lunn
2021-09-15  9:06   ` Daniel Palmer
2021-09-15 20:34     ` Andrew Lunn
2021-09-20  8:36       ` Daniel Palmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdYLURJCopH3hDuZTY8ce9-OxakELyFqwqkAVCsYmzF5kg@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=daniel@0x0f.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=romain.perier@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).