From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx. Date: Fri, 16 Jan 2015 10:53:51 +0100 Message-ID: References: <1415709535-31515-1-git-send-email-hongzhou.yang@mediatek.com> <1415709535-31515-3-git-send-email-hongzhou.yang@mediatek.com> <20141127101830.GP30369@pengutronix.de> <20141202135527.GM30369@pengutronix.de> <20150112122200.GC18908@pengutronix.de> <20150113161614.GF23940@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150113161614.GF23940-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sascha Hauer Cc: Rob Herring , Hongzhou Yang , Matthias Brugger , Sascha Hauer , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Grant Likely , "Joe.C" , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Catalin Marinas , Vladimir Murzin , Ashwin Chaugule , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , huang eddie , dandan.he-NuS5LvNUpcJWk0Htik3J/w@public.gmane.orgal List-Id: devicetree@vger.kernel.org On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer wrote: > On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: >> > You often talk about ambiguities. Could you give an example what >> > ambiguities you mean? >> >> What happened was this pins = ; arguments were sometimes >> strings and sometimes integers, that becomes strange to handle >> in code, ambiguous. > > I see. I like naming it 'pinmux' because that's what it is: pins and > mux settings. A plain 'pinno' suggests that it contains only pin mubers, > without mux setting. How about 'pin-no-mux'? We also could add an > explicit "pins-are-numbered" property instead of distinguishing this > by property names. I kind of like this "pins-are-numbered" thing. The other property for the pin, whether pinmux or pin-no-mux or pin-num-and-mux etc is no such big deal, as long as it's consistent and documented with the generic bindings. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html