From: Linus Walleij <linus.walleij@linaro.org>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
LDOC <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
LAK <linux-arm-kernel@lists.infradead.org>,
Sekhar Nori <nsekhar@ti.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>
Subject: Re: [PATCH v3 1/3] gpio: davinci: add OF support
Date: Fri, 11 Oct 2013 18:21:44 +0200 [thread overview]
Message-ID: <CACRpkdYSCgs9eiN4crqXYQrbU71H-6-u04C2a5OeHHu4Da3big@mail.gmail.com> (raw)
In-Reply-To: <CA+V-a8vH7VXqz=2cz-uD=YfRBRYrJ10K1Aptw28vV8gP+PiT2g@mail.gmail.com>
On Fri, Oct 11, 2013 at 6:18 PM, Prabhakar Lad
<prabhakar.csengg@gmail.com> wrote:
> On 10/11/13, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Fri, Oct 11, 2013 at 4:59 PM, Prabhakar Lad
>> <prabhakar.csengg@gmail.com> wrote:
>>> On 10/11/13, Linus Walleij <linus.walleij@linaro.org> wrote:
>>>> On Fri, Oct 4, 2013 at 6:03 PM, Prabhakar Lad
>>>> <prabhakar.csengg@gmail.com> wrote:
>>
>>>>> +- ti,davinci-gpio-irq-base: Base from where GPIO interrupt numbering
>>>>> starts.
>>>>
>>>> What is this?
>>>>
>>>> If I have ever ACKed this I have been drunk. I take it back.
>>>>
>>> here is the ACK https://patchwork.kernel.org/patch/2721181/
>>
>> And as suspected that version of the patch did not contain
>> this strange node property.
>>
> The property did exist in the patch 'intc_irq_num', I just renamed
> it and gave a proper description to it.
Hm yeah you're right ... I didn't understand what it was actually
doing until I saw the revised documentation, I though it was
stating the number of (hardware) IRQs, but it was stating the
Linux-internal offset.
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-10-11 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 16:03 [PATCH v3 0/3] GPIO DT support for da850 Prabhakar Lad
[not found] ` <1380902596-4693-1-git-send-email-sujithkv-l0cyMroinI0@public.gmane.org>
2013-10-04 16:03 ` [PATCH v3 1/3] gpio: davinci: add OF support Prabhakar Lad
2013-10-11 14:09 ` Linus Walleij
2013-10-11 14:59 ` Prabhakar Lad
2013-10-11 15:54 ` Linus Walleij
2013-10-11 16:18 ` Prabhakar Lad
2013-10-11 16:21 ` Linus Walleij [this message]
[not found] ` <CA+V-a8vH7VXqz=2cz-uD=YfRBRYrJ10K1Aptw28vV8gP+PiT2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-14 12:25 ` Grygorii Strashko
2013-11-02 15:49 ` Prabhakar Lad
2013-10-04 16:03 ` [PATCH v3 2/3] ARM: davinci: da850: add GPIO DT node Prabhakar Lad
2013-10-04 16:03 ` [PATCH v3 3/3] ARM: davinci: da850 evm: add GPIO pinumux entries " Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYSCgs9eiN4crqXYQrbU71H-6-u04C2a5OeHHu4Da3big@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=prabhakar.csengg@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).