From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97E3C6FD1C for ; Fri, 10 Mar 2023 08:15:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229885AbjCJIPL (ORCPT ); Fri, 10 Mar 2023 03:15:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbjCJIO4 (ORCPT ); Fri, 10 Mar 2023 03:14:56 -0500 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F5FC4E5F1 for ; Fri, 10 Mar 2023 00:14:51 -0800 (PST) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-536bbef1c5eso83414957b3.9 for ; Fri, 10 Mar 2023 00:14:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678436090; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=quyZEe5f9jO8KHwGwidAcKdKAq7OwgEj9SHFvyGmlZM=; b=Xz0I6e3/LJ+Lvtl+mKQOAS8yqInF8ZVaGOXpCLhNKcTzLKSlpWsOv0VEUV904Fu2Na +9A9pGlvxI7QVFYtmKKzM6zJvyU/OvN4b4AgPCCXGFTKagrmgS5ZX9VtQAHafqBxGC6m Eq+llrzRCUIwZLjEDh0TDX+4GFXgVT0pFUHmGANZJZ4RWQImFVpWbTBQIxQnCxbduSEp DOThgSu4tTiGbqDTZTrSz73IR46mvjGnqF8u8lCX2TyneUEkARXtWV0c4hQwYhagD2T6 s1pARgBUkdpxocdhAEHK1Lt7iH0sQ+LLaf/zWu8DCwBqOqVIgx7QnMe532eqyhHcCUGD RZCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678436090; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=quyZEe5f9jO8KHwGwidAcKdKAq7OwgEj9SHFvyGmlZM=; b=a/q9M6GNwKrWdSbbqhK9XMIXIMhTWrjpy8BYsig2msvmbzf6oZgGdkcxUCc0MM445P ve1kxIMA1y64DgBPDyzC22wsKneu5nJYwQ9S/NHrkCLlJ1qUy6pYQ4f9HX5APcNrIASM zCfVWxQJBLpKhr7VqCAEBnd0uk/WNY5sHZoTMrsWDGoHZspwRqTJ62UPjh4eR9hDUgyI oHPl5O6w3NIl6A/UvSkmDjJzcH5L3Qoguzf2+Mvf2+Eq3DHcYib8MuHT5ijJPdaV+zpL wG3OWWyNu2PlbY7MqzAVBktSyC4PPZfVlg6ARZ3VNoXLfQx93CzBwrxiREfdQSxY+Kc9 wVfg== X-Gm-Message-State: AO0yUKWYdCFL4BtzqOxPTEehXnGkCer0A0GEmO3oUEwSHA2b/GLV+E1z 1XjEELVeCD6emFlPDDyt3uncSuVJVaeTwXVOiSLM5KfA7AJqPE9c X-Google-Smtp-Source: AK7set//fuO9ytX567HKWcNCadQ41YDeuUs8D1KGFn4aNeWpTp2CgUPag3nEjA34y+PObgUwSM88FqO9+8UaF4aug+g= X-Received: by 2002:a81:b61a:0:b0:52e:cea7:f6e3 with SMTP id u26-20020a81b61a000000b0052ecea7f6e3mr15413943ywh.10.1678436090623; Fri, 10 Mar 2023 00:14:50 -0800 (PST) MIME-Version: 1.0 References: <20230309225041.477440-1-sre@kernel.org> <20230309225041.477440-2-sre@kernel.org> In-Reply-To: <20230309225041.477440-2-sre@kernel.org> From: Linus Walleij Date: Fri, 10 Mar 2023 09:14:39 +0100 Message-ID: Subject: Re: [PATCHv1 01/11] dt-bindings: power: supply: adc-battery: add binding To: Sebastian Reichel Cc: Matti Vaittinen , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sebastian, thanks for your patches! On Thu, Mar 9, 2023 at 11:50=E2=80=AFPM Sebastian Reichel = wrote: > Add binding for a battery that is only monitored via ADC > channels and simple status GPIOs. > > Signed-off-by: Sebastian Reichel This does look very useful. > +title: ADC battery > + > +maintainers: > + - Sebastian Reichel > + > +description: | > + Basic Battery, which only reports (in circuit) voltage and optionally > + current via an ADC channel. I would over-specify: "voltage over the terminals" and "current out of the battery" so this cannot be misunderstood. + this text: It can also optionally indicate that the battery is full by pulling a GPIO line. > + charged-gpios: > + description: > + GPIO which signals that the battery is fully charged. It doesn't say how, I guess either this is an analog circuit (!) or a charger IC? If it doesn't matter, no big deal, but if something is implicit here, then spell it out please. > + fuel-gauge { This techno-lingo/slang term is a bit unfortunate, but if there are precedents then stick with it. The correct term could be something like battery-capacity-meter I suppose. Yours, Linus Walleij