From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 09/11] mmc: omap_hsmmc: enhance pinctrl support Date: Tue, 4 Jun 2013 09:19:57 +0200 Message-ID: References: <1369995191-20855-1-git-send-email-gururaja.hebbar@ti.com> <1369995191-20855-10-git-send-email-gururaja.hebbar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org To: Hebbar Gururaja Cc: Kevin Hilman , Grant Likely , Rob Herring , "davinci-linux-open-source@linux.davincidsp.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , Russell King - ARM Linux , "linux-kernel@vger.kernel.org" , Vaibhav Bedia , sudhakar.raj@ti.com, Balaji T K , Chris Ball , "linux-mmc@vger.kernel.org" , Linux-OMAP List-Id: devicetree@vger.kernel.org On Tue, Jun 4, 2013 at 9:11 AM, Linus Walleij wrote: > On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja > wrote: > >> Amend the hsmmc controller to optionally take a pin control handle and >> set the state of the pins to: >> >> - "default" on boot, resume and before performing a mmc transfer >> - "idle" after initial default, after resume default, and after each >> mmc/sd card access >> - "sleep" on suspend() >> >> By optionally putting the pins into sleep state in the suspend callback >> we can accomplish two things. >> - One is to minimize current leakage from pins and thus save power, >> - second, we can prevent the IP from driving pins output in an >> uncontrolled manner, which may happen if the power domain drops the >> domain regulator. >> >> If any of the above pin states are missing in dt, a warning message >> about the missing state is displayed. >> If certain pin-states are not available, to remove this warning message >> pass respective state name with null phandler. >> >> Signed-off-by: Hebbar Gururaja >> Cc: Balaji T K >> Cc: Chris Ball >> Cc: linux-mmc@vger.kernel.org >> Cc: linux-omap@vger.kernel.org > > This is perfectly correct. > Acked-by: Linus Walleij So please consider my other option given in patch 2 instead. Yours, Linus Walleij