From: Linus Walleij <linus.walleij@linaro.org>
To: Y Vo <yvo@apm.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>, Phong Vo <pvo@apm.com>,
Toan Le <toanle@apm.com>, patches <patches@apm.com>
Subject: Re: [PATCH v2 RESEND 1/3] gpio: Add APM X-Gene standby GPIO controller driver
Date: Fri, 16 Jan 2015 16:19:13 +0100 [thread overview]
Message-ID: <CACRpkdYjsQFgbZMSE6v1vQRP5OK-4vvDzOrk07NHxywXZ-4sGg@mail.gmail.com> (raw)
In-Reply-To: <CAL4ahLfGNc1sL-hr7bZi_pcxjz7CNHjPRSPnJf_TUCGsbweaDA@mail.gmail.com>
On Wed, Jan 14, 2015 at 9:27 AM, Y Vo <yvo@apm.com> wrote:
> On Tue, Jan 13, 2015 at 4:40 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> This looks very much like a memory-mapped standard GPIO controller,
>> use drivers/gpio/gpio-generic.c with some IRQ add-on, compare
>> to any other driver selecting GPIO_GENERIC for guidance:
>> drivers/gpio/gpio-74xx-mmio.c, gpio-dwapb.c etc.
>
> You mean I must rewrite to use GPIO_GENERIC follow gpio-74xx-mmio.c,
> gpio-dwapb.c ?
Yes.
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-01-16 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 5:10 [PATCH v2 RESEND 0/3] gpio: Add APM X-Gene standy platform GPIO driver Y Vo
2014-12-17 5:10 ` [PATCH v2 RESEND 1/3] gpio: Add APM X-Gene standby GPIO controller driver Y Vo
2015-01-13 9:40 ` Linus Walleij
2015-01-14 8:27 ` Y Vo
2015-01-16 15:19 ` Linus Walleij [this message]
2014-12-17 5:10 ` [PATCH v2 RESEND 2/3] Documentation: gpio: Add APM X-Gene standby GPIO controller DTS binding Y Vo
2015-01-13 9:25 ` Linus Walleij
2015-01-13 9:41 ` Y Vo
2015-01-15 16:16 ` Linus Walleij
[not found] ` <1418793050-26927-1-git-send-email-yvo-qTEPVZfXA3Y@public.gmane.org>
2014-12-17 5:10 ` [PATCH v2 RESEND 3/3] arm64:dts: Add APM X-Gene standby GPIO controller DTS entries Y Vo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYjsQFgbZMSE6v1vQRP5OK-4vvDzOrk07NHxywXZ-4sGg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@apm.com \
--cc=pvo@apm.com \
--cc=toanle@apm.com \
--cc=yvo@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).