From: Linus Walleij <linus.walleij@linaro.org>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/4] pinctrl: iproc: Allow PINCONF to be disabled completely
Date: Fri, 15 Apr 2016 10:24:06 +0200 [thread overview]
Message-ID: <CACRpkdYmGUxQu5Sagw+J70wpFc+3Smg3V8mKxF2OFOhbMATYDw@mail.gmail.com> (raw)
In-Reply-To: <1460506523-6249-5-git-send-email-ray.jui@broadcom.com>
On Wed, Apr 13, 2016 at 2:15 AM, Ray Jui <ray.jui@broadcom.com> wrote:
> In some of the future iProc based SoCs, pinconf is handled by another
> block and the iProc GPIO controller is solely used as a GPIO controller.
> This patch adds support of a new compatible string "brcm,iproc-gpio-only",
> that is introduced to handle this case, where pinconf functions in this
> driver are completely disabled
>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
> Reviewed-by: Jon Mason <jon.mason@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
If this was entirely true, then the driver should end up only executing
[devm_]gpiochip_add_data() but that does not seem to be the case.
You are still registering a pin controller, right? Just disabling some of
the pin config options. The pin multiplexing is still there, right?
Then it is not "solely a GPIO controller". Not at all.
This patch set needs some elaboration I think.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-04-15 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 0:15 [PATCH 0/4] Additional iProc GPIO support Ray Jui
2016-04-13 0:15 ` [PATCH 1/4] dt-bindings: Update iProc GPIO bindings Ray Jui
2016-04-13 0:15 ` [PATCH 2/4] pinctrl: iproc: Allow certain PINCONF functions to be disabled Ray Jui
2016-04-15 8:20 ` Linus Walleij
2016-04-18 19:22 ` Ray Jui
[not found] ` <1460506523-6249-1-git-send-email-ray.jui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-04-13 0:15 ` [PATCH 3/4] dt-bindings: Update iProc GPIO bindings Ray Jui
2016-04-14 14:38 ` Rob Herring
2016-04-18 18:27 ` Ray Jui
2016-04-13 0:15 ` [PATCH 4/4] pinctrl: iproc: Allow PINCONF to be disabled completely Ray Jui
2016-04-15 8:24 ` Linus Walleij [this message]
2016-04-18 19:30 ` Ray Jui
2016-04-29 8:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYmGUxQu5Sagw+J70wpFc+3Smg3V8mKxF2OFOhbMATYDw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).