From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 07/11] ARM:stixxxx: Add STiH416 SOC support Date: Wed, 19 Jun 2013 20:34:52 +0200 Message-ID: References: <1370855828-5318-1-git-send-email-srinivas.kandagatla@st.com> <1370856425-7135-1-git-send-email-srinivas.kandagatla@st.com> <3733079.FxbR14kFrs@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3733079.FxbR14kFrs@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Arnd Bergmann Cc: Mauro Carvalho Chehab , Srinivas KANDAGATLA , Russell King - ARM Linux , Samuel Ortiz , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Stephen Gallimore , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Grant Likely , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Rob Herring , Stuart Menefy , Mark Brown , John Stultz , Thomas Gleixner , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Greg Kroah-Hartman , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Andrew Morton List-Id: devicetree@vger.kernel.org On Mon, Jun 10, 2013 at 3:52 PM, Arnd Bergmann wrote: > On Monday 10 June 2013 10:27:05 Srinivas KANDAGATLA wrote: > >> + soc { >> + pin-controller-sbc { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "st,stih416-pinctrl", "simple-bus"; > > Why is this both its own device with a compatible string and a > "simple-bus" at the same time? Wouldn't it be simpler to just > scan the child device nodes from the "st,stih416-pinctrl" > driver instead of having a separate platform_driver for them? I think that in my comments to the pinctrl driver I had some similar comment, so it's probably a good idea to look into this. Yours, Linus Walleij