From: Linus Walleij <linus.walleij@linaro.org>
To: Sander Vanheule <sander@svanheule.net>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Bert Vermeulen <bert@biot.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/6] gpio: realtek-otto: Support reversed port layouts
Date: Thu, 21 Apr 2022 01:01:37 +0200 [thread overview]
Message-ID: <CACRpkdYmKbHOZChSHjB-ykQCyCziwYTO_+Ai2vheo0y-vD_akA@mail.gmail.com> (raw)
In-Reply-To: <7105ae382d7b328102f66b39ffd7c94998e85265.1649533972.git.sander@svanheule.net>
On Sat, Apr 9, 2022 at 9:56 PM Sander Vanheule <sander@svanheule.net> wrote:
> + if (dev_flags & GPIO_PORTS_REVERSED) {
> + bgpio_flags = 0;
> + ctrl->port_offset_u8 = realtek_gpio_port_offset_u8_rev;
> + ctrl->port_offset_u16 = realtek_gpio_port_offset_u16_rev;
> + } else {
> + bgpio_flags = BGPIOF_BIG_ENDIAN_BYTE_ORDER;
> + ctrl->port_offset_u8 = realtek_gpio_port_offset_u8;
> + ctrl->port_offset_u16 = realtek_gpio_port_offset_u16;
> + }
Just checking: is this really a different silicon block, or is this
GPIO_PORTS_REVERSED flag passed around just a way of saying:
if (!IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) ...?
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-04-20 23:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 19:55 [PATCH v1 0/6] Support for RTL930x/RTL931x GPIOs Sander Vanheule
2022-04-09 19:55 ` [PATCH v1 1/6] dt-bindings: gpio: realtek-otto: Add rtl9300 compatible Sander Vanheule
2022-04-10 14:16 ` Krzysztof Kozlowski
2022-04-10 14:34 ` Sander Vanheule
2022-04-09 19:55 ` [PATCH v1 2/6] gpio: realtek-otto: Support reversed port layouts Sander Vanheule
2022-04-20 23:01 ` Linus Walleij [this message]
2022-04-21 7:55 ` Sander Vanheule
2022-04-22 21:14 ` Linus Walleij
2022-04-09 19:55 ` [PATCH v1 3/6] gpio: realtek-otto: Support per-cpu interrupts Sander Vanheule
2022-04-20 23:04 ` Linus Walleij
2022-04-21 9:48 ` Marc Zyngier
2022-04-22 7:04 ` Sander Vanheule
2022-04-22 20:40 ` Sander Vanheule
2022-04-09 19:55 ` [PATCH v1 4/6] gpio: realtek-otto: Add RTL930x support Sander Vanheule
2022-04-09 19:55 ` [PATCH v1 5/6] dt-bindings: gpio: realtek-otto: Add rtl9310 compatible Sander Vanheule
2022-04-10 14:16 ` Krzysztof Kozlowski
2022-04-09 19:55 ` [PATCH v1 6/6] gpio: realtek-otto: Add RTL931x support Sander Vanheule
2022-04-11 12:31 ` [PATCH v1 0/6] Support for RTL930x/RTL931x GPIOs Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYmKbHOZChSHjB-ykQCyCziwYTO_+Ai2vheo0y-vD_akA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bert@biot.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).