From: Linus Walleij <linus.walleij@linaro.org>
To: Feng Kan <fkan@apm.com>
Cc: Alexandre Courbot <gnurou@gmail.com>, patches <patches@apm.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] gpio: Add APM X-Gene SoC GPIO controller support
Date: Wed, 28 May 2014 21:10:24 +0200 [thread overview]
Message-ID: <CACRpkdYoebS-SzCPBnssjNMN_-mxd2GoPwiXHfZUL9HwMeGVzw@mail.gmail.com> (raw)
In-Reply-To: <CAL85gmCZD90UUZgC0-X4hui2L1V5TuH++o3fA20pRF_ZQEpDQw@mail.gmail.com>
On Tue, May 27, 2014 at 6:59 PM, Feng Kan <fkan@apm.com> wrote:
> I will break out the gpio to separate
> device nodes as instructed, I will have to use the reg attribute to offset
> bank registers. Please let me know if it is acceptable.
Yeah sure regs = <a>, <b>, <c> for a single node is OK if that's what
you mean.
> gfc_gpio_fl0 GFC42'h1701c00c
> gfc_gpio_fl0_mux GFC42'h1701c010
> gfc_gpio_fl1 GFC42'h1701c018
> gfc_gpio_fl1_mux GFC42'h1701c01c
> gfc_gpio_fl2 GFC42'h1701c024
> gfc_gpio_fl2_mux GFC42'h1701c028
> gfc_gpio_fl0_od GFC42'h1701c030
> gfc_gpio_fl1_od GFC42'h1701c034
> gfc_gpio_fl2_od GFC42'h1701c038
Strange syntax in the last line there. GFC42'h uhm.
But that looks a bit mingled actually. However I think you will be
much happier if you split it into individual devices as I wanted to.
It will be easier to maintain and simpler code even if the device tree
may look a bit strange.
Yours,
Linus Walleij
next prev parent reply other threads:[~2014-05-28 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1400263432-922-1-git-send-email-fkan@apm.com>
[not found] ` <1400263432-922-2-git-send-email-fkan@apm.com>
2014-05-20 6:04 ` [PATCH 1/3] gpio: Add APM X-Gene SoC GPIO controller support Alexandre Courbot
2014-05-20 23:54 ` Feng Kan
2014-05-25 7:35 ` Alexandre Courbot
2014-05-27 8:25 ` Linus Walleij
2014-05-27 16:59 ` Feng Kan
2014-05-28 17:01 ` Feng Kan
2014-05-28 19:10 ` Rob Herring
2014-05-28 19:10 ` Linus Walleij [this message]
2014-05-27 7:59 ` Linus Walleij
[not found] ` <1400263432-922-4-git-send-email-fkan@apm.com>
2014-05-20 6:11 ` [PATCH 3/3] Documentation: gpio: Add APM X-Gene SoC GPIO controller DTS binding Alexandre Courbot
2014-05-27 8:30 ` Linus Walleij
[not found] ` <1400263432-922-3-git-send-email-fkan@apm.com>
2014-05-27 8:27 ` [PATCH 2/3] arm64:dts: Add APM X-Gene SoC GPIO controller DTS entries Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYoebS-SzCPBnssjNMN_-mxd2GoPwiXHfZUL9HwMeGVzw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=fkan@apm.com \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@apm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).