From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 1/3] gpio: Add APM X-Gene SoC GPIO controller support Date: Wed, 28 May 2014 21:10:24 +0200 Message-ID: References: <1400263432-922-1-git-send-email-fkan@apm.com> <1400263432-922-2-git-send-email-fkan@apm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org To: Feng Kan Cc: Alexandre Courbot , patches , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tue, May 27, 2014 at 6:59 PM, Feng Kan wrote: > I will break out the gpio to separate > device nodes as instructed, I will have to use the reg attribute to offset > bank registers. Please let me know if it is acceptable. Yeah sure regs = , , for a single node is OK if that's what you mean. > gfc_gpio_fl0 GFC42'h1701c00c > gfc_gpio_fl0_mux GFC42'h1701c010 > gfc_gpio_fl1 GFC42'h1701c018 > gfc_gpio_fl1_mux GFC42'h1701c01c > gfc_gpio_fl2 GFC42'h1701c024 > gfc_gpio_fl2_mux GFC42'h1701c028 > gfc_gpio_fl0_od GFC42'h1701c030 > gfc_gpio_fl1_od GFC42'h1701c034 > gfc_gpio_fl2_od GFC42'h1701c038 Strange syntax in the last line there. GFC42'h uhm. But that looks a bit mingled actually. However I think you will be much happier if you split it into individual devices as I wanted to. It will be easier to maintain and simpler code even if the device tree may look a bit strange. Yours, Linus Walleij