From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding Date: Fri, 30 Jan 2015 15:18:16 +0100 Message-ID: References: <1417131990-17954-1-git-send-email-rjui@broadcom.com> <1417131990-17954-2-git-send-email-rjui@broadcom.com> <54B01D44.5080601@broadcom.com> <54C1AE9F.3020407@broadcom.com> <54C1EEF3.4040406@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <54C1EEF3.4040406-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ray Jui Cc: Grant Likely , Rob Herring , Scott Branden , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , bcm-kernel-feedback-list , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, Jan 23, 2015 at 7:49 AM, Ray Jui wrote: > I dig into the pinctrl framework code a bit more and found that I can > use pinctrl_request_gpio from the GPIO driver and implement > gpio_request_enable in the pinctrl driver. Yep :) ain't it nice. > The only problem I see now is that these APIs seem to expect the use of > global GPIO numbers? No they don't, only if you use the deprecated pinctrl_add_gpio_range(). Instead, when you register your struct gpio_chip, use gpiochip_add_pin_range() and this will use relative offsets without relying on global GPIO numbers. This latter call replaces pinctrl_add_gpio_range(). > I hope I'm not missing something here? You're missing gpiochip_add_pin_range() ;) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html