* [PATCH] dt-bindings: leds: common: add disk write/read and usb-host
@ 2021-05-08 19:36 Corentin Labbe
2021-05-08 20:43 ` Linus Walleij
2021-05-11 19:49 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Corentin Labbe @ 2021-05-08 19:36 UTC (permalink / raw)
To: pavel, robh+dt, jacek.anaszewski, linus.walleij
Cc: devicetree, linux-kernel, linux-leds, Corentin Labbe
The triggers enum misses 3 cases used by gemini DT.
usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
so we add also as valid trigger usb-gadget which was added along in this
commit.
disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
Documentation/devicetree/bindings/leds/common.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index b1f363747a62..a9b8c21779e3 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -89,6 +89,8 @@ properties:
- heartbeat
# LED indicates disk activity
- disk-activity
+ - disk-read
+ - disk-write
# LED indicates IDE disk activity (deprecated), in new implementations
# use "disk-activity"
- ide-disk
@@ -97,6 +99,8 @@ properties:
# LED alters the brightness for the specified duration with one software
# timer (requires "led-pattern" property)
- pattern
+ - usb-gadget
+ - usb-host
led-pattern:
description: |
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: leds: common: add disk write/read and usb-host
2021-05-08 19:36 [PATCH] dt-bindings: leds: common: add disk write/read and usb-host Corentin Labbe
@ 2021-05-08 20:43 ` Linus Walleij
2021-05-11 19:49 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-05-08 20:43 UTC (permalink / raw)
To: Corentin Labbe
Cc: Pavel Machek, Rob Herring, Jacek Anaszewski,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Linux LED Subsystem
On Sat, May 8, 2021 at 9:37 PM Corentin Labbe <clabbe@baylibre.com> wrote:
> The triggers enum misses 3 cases used by gemini DT.
> usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
> so we add also as valid trigger usb-gadget which was added along in this
> commit.
>
> disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Good catch!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: leds: common: add disk write/read and usb-host
2021-05-08 19:36 [PATCH] dt-bindings: leds: common: add disk write/read and usb-host Corentin Labbe
2021-05-08 20:43 ` Linus Walleij
@ 2021-05-11 19:49 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-05-11 19:49 UTC (permalink / raw)
To: Corentin Labbe
Cc: pavel, devicetree, linux-kernel, linus.walleij, jacek.anaszewski,
robh+dt, linux-leds
On Sat, 08 May 2021 19:36:54 +0000, Corentin Labbe wrote:
> The triggers enum misses 3 cases used by gemini DT.
> usb-host was added via commit 0cfbd328d60f ("usb: Add LED triggers for USB activity")
> so we add also as valid trigger usb-gadget which was added along in this
> commit.
>
> disk-read/disk-write were added by commit d1ed7c558612 ("leds: Extends disk trigger for reads and writes")
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-12 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-08 19:36 [PATCH] dt-bindings: leds: common: add disk write/read and usb-host Corentin Labbe
2021-05-08 20:43 ` Linus Walleij
2021-05-11 19:49 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).