From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 2/7] gpiolib: Support purely name based gpiod lookup in device trees Date: Tue, 22 Apr 2014 17:00:17 +0200 Message-ID: References: <1397544101-18135-1-git-send-email-wens@csie.org> <1397544101-18135-3-git-send-email-wens@csie.org> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1397544101-18135-3-git-send-email-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Johannes Berg , "John W. Linville" , Maxime Ripard , Arnd Bergmann , Heikki Krogerus , Mika Westerberg , Alexandre Courbot , Stephen Warren , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-wireless , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi List-Id: devicetree@vger.kernel.org On Tue, Apr 15, 2014 at 8:41 AM, Chen-Yu Tsai wrote: > This patch enables gpio-names based gpiod lookup in device tree usage, > which ignores the index passed to gpiod_get_index. If this fails, fall > back to the original function-index ("con_id"-gpios) based lookup scheme, > for backward compatibility and any drivers needing more than one GPIO > for any function. > > Signed-off-by: Chen-Yu Tsai This looks a bit scary and I cannot claim to realize the entire semantic effect of this patch, but if it's the way to go then OK. Acked-by: Linus Walleij Shall I just apply this to the GPIO tree or are you carrying it along with the other stuff? Yours, Linus Walleij