Re: [PATCH v2 1/4] dt-bindings: crypto: Let STM32 define Ux500 CRYP

[Linus Walleij <linus.walleij@linaro.org>]

On Sun, Nov 27, 2022 at 1:44 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> On 25/11/2022 23:32, Linus Walleij wrote:
> > This adds device tree bindings for the Ux500 CRYP block
> > as a compatible in the STM32 CRYP bindings.
> >
> > The Ux500 CRYP binding has been used for ages in the kernel
> > device tree for Ux500 but was never documented, so fill in
> > the gap by making it a sibling of the STM32 CRYP block,
> > which is what it is.
> >
> > The relationship to the existing STM32 CRYP block is pretty
> > obvious when looking at the register map, and I have written
> > patches to reuse the STM32 CRYP driver on the Ux500.
> >
> > The two properties added are DMA channels and power domain.
> > Power domains are a generic SoC feature and the STM32 variant
> > also has DMA channels.
> >
> > Cc: devicetree@vger.kernel.org
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > Cc: Lionel Debieve <lionel.debieve@foss.st.com>
> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > ChangeLog v1->v2:
> > - Drop the second (new) example.
> > ---
> >  .../bindings/crypto/st,stm32-cryp.yaml        | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-cryp.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-cryp.yaml
> > index ed23bf94a8e0..6759c5bf3e57 100644
> > --- a/Documentation/devicetree/bindings/crypto/st,stm32-cryp.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/st,stm32-cryp.yaml
> > @@ -6,12 +6,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> >  title: STMicroelectronics STM32 CRYP bindings
> >
> > +description: The STM32 CRYP block is built on the CRYP block found in
> > +  the STn8820 SoC introduced in 2007, and subsequently used in the U8500
> > +  SoC in 2010.
> > +
> >  maintainers:
> >    - Lionel Debieve <lionel.debieve@foss.st.com>
> >
> >  properties:
> >    compatible:
> >      enum:
> > +      - st,stn8820-cryp
> > +      - stericsson,ux500-cryp
> >        - st,stm32f756-cryp
> >        - st,stm32mp1-cryp
> >
> > @@ -27,6 +33,19 @@ properties:
> >    resets:
> >      maxItems: 1
> >
> > +  dmas:
> > +    items:
> > +      - description: mem2cryp DMA channel
> > +      - description: cryp2mem DMA channel
> > +
> > +  dma-names:
> > +    items:
> > +      - const: mem2cryp
> > +      - const: cryp2mem
>
> Usually these are called rx/tx, but I understand you are documenting
> existing usage from DTS or driver? In such case:

It's in the driver. Dunno how to do it for the future, we could
deprecate these and add rx/tx as preferred in a separate
patch.

> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks!

Yours,
Linus Walleij