From: Linus Walleij <linus.walleij@linaro.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Chris Morgan <macroalpha82@gmail.com>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, maccraft123mc@gmail.com,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org,
thierry.reding@gmail.com, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH V4 2/3] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel
Date: Tue, 6 Dec 2022 14:58:41 +0100 [thread overview]
Message-ID: <CACRpkdZ1XX9Od4eUnQRYwcfLjs8Ct-reXNQvv1zaxmj85-4jdg@mail.gmail.com> (raw)
In-Reply-To: <7746700.MhkbZ0Pkbq@diego>
On Sat, Dec 3, 2022 at 11:18 AM Heiko Stübner <heiko@sntech.de> wrote:
> Though in past projects I've seen the same display-controller used with
> different panels (and different dsi-init-sequences). In one project the
> display manufacturer even EOL'ed the first panel and provided a replacement
> with said same display controller (and a different init) - but the
> datasheets for the display-controller were for the same chip still.
>
> So while in my experience the actual display name from the manufacturer
> identifies the display + controller combo, I don't really think you can
> go the other way with the controller name identifying the display+controller
> combination.
I don't mean we should do that.
What I mean is:
- Name the driver after the controller, if we know which one it is,
such as panel-novatek-nt35510.c
- Provide identifications of the controller+panel combo in e.g.
DT compatible strings, provide init data as arrays in the per-variant
match data (or similar for ACPI).
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-12-06 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 17:29 [PATCH V4 0/3] drm/panel: Add Samsung AMS495QA01 Panel Chris Morgan
2022-11-29 17:29 ` [PATCH V4 1/3] dt-bindings: display: panel: Add Samsung AMS495QA01 Chris Morgan
2022-12-01 23:34 ` Rob Herring
2022-12-02 23:27 ` Linus Walleij
2022-11-29 17:29 ` [PATCH V4 2/3] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel Chris Morgan
2022-12-03 9:03 ` Linus Walleij
2022-12-03 10:18 ` Heiko Stübner
2022-12-06 13:58 ` Linus Walleij [this message]
2022-12-03 19:01 ` Chris Morgan
2022-12-06 14:24 ` Linus Walleij
2022-11-29 17:29 ` [PATCH V4 3/3] arm64: dts: rockchip: add display to RG503 Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ1XX9Od4eUnQRYwcfLjs8Ct-reXNQvv1zaxmj85-4jdg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).