From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [RFC 6/8] ARM:stih41x: Add STiH416 SOC support Date: Wed, 15 May 2013 21:41:01 +0200 Message-ID: References: <1368022187-1633-1-git-send-email-srinivas.kandagatla@st.com> <1368022318-2380-1-git-send-email-srinivas.kandagatla@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1368022318-2380-1-git-send-email-srinivas.kandagatla-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Srinivas KANDAGATLA Cc: "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Viresh Kumar , Will Deacon , Jiri Slaby , Russell King - ARM Linux , Samuel Ortiz , Nicolas Pitre , Stephen Gallimore , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jason Cooper , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Rob Herring , Stuart Menefy , Stephen Warren , Dong Aisheng , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Greg Kroah-Hartman , Mark Brown , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, May 8, 2013 at 4:11 PM, Srinivas KANDAGATLA wrote: > From: Srinivas Kandagatla > > The STiH416 is advanced HD AVC processor with 3D graphics acceleration > and 1.2-GHz ARM Cortex-A9 SMP CPU. > > Signed-off-by: Srinivas Kandagatla > CC: Stephen Gallimore > CC: Stuart Menefy (...) This stuff is looking really good. > +++ b/arch/arm/boot/dts/stih416.dtsi > @@ -0,0 +1,103 @@ > +/* > + * Copyright (C) 2012 STMicroelectronics Limited. > + * Author: Srinivas Kandagatla > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * publishhed by the Free Software Foundation. > + */ > +#include "stih41x.dtsi" > +#include "stih416-clock.dtsi" > +#include "stih416-pinctrl.dtsi" Nice layering here! > diff --git a/arch/arm/boot/dts/stih416.h b/arch/arm/boot/dts/stih416.h > new file mode 100644 > index 0000000..2e27792 > --- /dev/null > +++ b/arch/arm/boot/dts/stih416.h I've seen that people start to put these into: include/dt-bindings/ With one include per driver subsystem. I suggest you follow this pattern. Yours, Linus Walleij