From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2] gpio: keystone: add dsp gpio controller driver Date: Fri, 8 Aug 2014 14:53:50 +0200 Message-ID: References: <1406126699-10053-1-git-send-email-grygorii.strashko@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1406126699-10053-1-git-send-email-grygorii.strashko@ti.com> Sender: linux-gpio-owner@vger.kernel.org To: Grygorii Strashko Cc: Santosh Shilimkar , Alexandre Courbot , "linux-gpio@vger.kernel.org" , ivan.khoronzhuk@ti.com, Muralidharan Karicheri , Rob Herring , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Varka Bhadram List-Id: devicetree@vger.kernel.org On Wed, Jul 23, 2014 at 4:44 PM, Grygorii Strashko wrote: > From: Murali Karicheri > > On Keystone SOCs, ARM host can send interrupts to DSP cores using the > DSP GPIO controller IP. Each DSP GPIO controller provides 28 IRQ signals for > each DSP core. This is one of the component used by the IPC mechanism used > on Keystone SOCs. > > Keystone 2 DSP GPIO controller has specific features: > - each GPIO can be configured only as output pin; > - setting GPIO value to 1 causes IRQ generation on target DSP core; > - reading pin value returns 0 - if IRQ was handled or 1 - IRQ is still > pending. > > Signed-off-by: Murali Karicheri > Signed-off-by: Grygorii Strashko > --- > Changes in v2: > - minor comments applied Hm so there was one major comment, quoting myself: "And if you proceed with this, please integrate it with drivers/gpio/gpio-syscon.c, I don't need more special syscons GPIO handlers." Maybe you missed this in the midst of the other discussions about whether this is GPIO at all, but that comment still stands even if you talk me down on the generality of this driver. > +++ b/Documentation/devicetree/bindings/gpio/gpio-keystone.txt Make this follow the style in: Documentation/devicetree/bindings/gpio/cirrus,clps711x-mctrl-gpio.txt Yours, Linus Walleij