From: Linus Walleij <linus.walleij@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
marex@denx.de, conor+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org,
quic_jesszhan@quicinc.com, neil.armstrong@linaro.org,
jagan@amarulasolutions.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 1/3] drm/panel: st7701: Fix AVCL calculation
Date: Tue, 12 Dec 2023 00:43:47 +0100 [thread overview]
Message-ID: <CACRpkdZDJRdCYh4R4b0CsMMKm14PmToHCPgVDpio3Tb4n4ovOQ@mail.gmail.com> (raw)
In-Reply-To: <20231208154847.130615-2-macroalpha82@gmail.com>
On Fri, Dec 8, 2023 at 4:48 PM Chris Morgan <macroalpha82@gmail.com> wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> The AVCL register, according to the datasheet, comes in increments
> of -0.2v between -4.4v (represented by 0x0) to -5.0v (represented
> by 0x3). The current calculation is done by adding the defined
> AVCL value in mV to -4400 and then dividing by 200 to get the register
> value. Unfortunately if I subtract -4400 from -4400 I get -8800, which
> divided by 200 gives me -44. If I instead subtract -4400 from -4400
> I get 0, which divided by 200 gives me 0. Based on the datasheet this
> is the expected register value.
>
> Fixes: 83b7a8e7e88e ("drm/panel/panel-sitronix-st7701: Parametrize voltage and timing")
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Good catch!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2023-12-11 23:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 15:48 [PATCH 0/3] Add Support for RG-ARC Panel Chris Morgan
2023-12-08 15:48 ` [PATCH 1/3] drm/panel: st7701: Fix AVCL calculation Chris Morgan
2023-12-11 8:29 ` neil.armstrong
2023-12-11 23:43 ` Linus Walleij [this message]
2023-12-08 15:48 ` [PATCH 2/3] dt-bindings: display: st7701: Add Anbernic RG-ARC panel Chris Morgan
2023-12-09 8:13 ` Krzysztof Kozlowski
2023-12-09 23:38 ` Linus Walleij
2023-12-08 15:48 ` [PATCH 3/3] drm/panel: st7701: Add Anbernic RG-ARC Panel Support Chris Morgan
2023-12-11 8:28 ` neil.armstrong
2023-12-11 23:44 ` Linus Walleij
2023-12-11 9:16 ` [PATCH 0/3] Add Support for RG-ARC Panel Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZDJRdCYh4R4b0CsMMKm14PmToHCPgVDpio3Tb4n4ovOQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).