devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Jean-Christophe PLAGNIOL-VILLARD
	<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 5/6] ARM: integrator: convert AMBA devices to device tree
Date: Sun, 19 Aug 2012 00:42:12 +0200	[thread overview]
Message-ID: <CACRpkdZDMxk30YTkrumRveR3OuWptSpzNevrAvC2FxYShOZp-A@mail.gmail.com> (raw)
In-Reply-To: <20120816124002.GB7439-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>

On Thu, Aug 16, 2012 at 2:40 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> wrote:
> On 14:16 Thu 16 Aug     , Linus Walleij wrote:
>> +/* For the Device Tree, add in the UART callbacks as AUXDATA */
>> +static struct of_dev_auxdata ap_auxdata_lookup[] __initdata = {
>> +     OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_RTC_BASE,
>> +             "rtc", NULL),
>> +     OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_UART0_BASE,
>> +             "uart0", &integrator_uart_data),
>> +     OF_DEV_AUXDATA("arm,primecell", INTEGRATOR_UART1_BASE,
>> +             "uart1", &integrator_uart_data),
>> +     OF_DEV_AUXDATA("arm,primecell", KMI0_BASE,
>> +             "kmi0", NULL),
>> +     OF_DEV_AUXDATA("arm,primecell", KMI1_BASE,
>> +             "kmi1", NULL),
>> +     { /* sentinel */ },

> why that?

Based on similar code by Grant in arch/arm/mach-versatile/core.c
also ending with a {}. Also at other places ... I though this terminated
the list iteration, is it not needed anymore?

Yours,
Linus Walleij

  parent reply	other threads:[~2012-08-18 22:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16 12:16 [PATCH 5/6] ARM: integrator: convert AMBA devices to device tree Linus Walleij
     [not found] ` <1345119373-22774-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-08-16 12:40   ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]     ` <20120816124002.GB7439-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-08-18 22:42       ` Linus Walleij [this message]
2012-08-20  8:02         ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]           ` <20120820080210.GF7439-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-08-30 23:30             ` Linus Walleij
2012-08-16 13:56   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZDMxk30YTkrumRveR3OuWptSpzNevrAvC2FxYShOZp-A@mail.gmail.com \
    --to=linus.walleij-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).