From: Linus Walleij <linus.walleij@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Sudeep Holla <Sudeep.Holla@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Guenter Roeck <linux@roeck-us.net>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 1/2] of: Support using 'mask' in making device bus id
Date: Tue, 9 Nov 2021 23:20:17 +0100 [thread overview]
Message-ID: <CACRpkdZOuhA8w4CYetBKfaZ_wKT4QgKe=bffdYDTB68ihVE3-A@mail.gmail.com> (raw)
In-Reply-To: <20211109164650.2233507-2-robh@kernel.org>
On Tue, Nov 9, 2021 at 5:46 PM Rob Herring <robh@kernel.org> wrote:
> Commit 25b892b583cc ("ARM: dts: arm: Update register-bit-led nodes
> 'reg' and node names") added a 'reg' property to nodes. This change has
> the side effect of changing how the kernel generates the device name.
> The assumption was a translatable 'reg' address is unique. However, in
> the case of the register-bit-led binding (and a few others) that is not
> the case. The 'mask' property must also be used in this case to make a
> unique device name.
>
> Fixes: 25b892b583cc ("ARM: dts: arm: Update register-bit-led nodes 'reg' and node names")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Cc: stable@vger.kernel.org
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-11-09 22:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 16:46 [PATCH 0/2] Fix Arm Ltd board node name collisions Rob Herring
2021-11-09 16:46 ` [PATCH 1/2] of: Support using 'mask' in making device bus id Rob Herring
2021-11-09 22:20 ` Linus Walleij [this message]
2021-11-09 16:46 ` [PATCH 2/2] clk: versatile: clk-icst: Ensure clock names are unique Rob Herring
2021-11-09 22:21 ` Linus Walleij
2021-11-11 0:41 ` Stephen Boyd
2021-11-09 22:22 ` [PATCH 0/2] Fix Arm Ltd board node name collisions Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2021-11-09 19:43 [PATCH 1/2] of: Support using 'mask' in making device bus id Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZOuhA8w4CYetBKfaZ_wKT4QgKe=bffdYDTB68ihVE3-A@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=Sudeep.Holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).