From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller node Date: Tue, 27 Oct 2015 10:41:14 +0100 Message-ID: References: <1445233398-27129-1-git-send-email-pramodku@broadcom.com> <1445233398-27129-6-git-send-email-pramodku@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1445233398-27129-6-git-send-email-pramodku@broadcom.com> Sender: linux-gpio-owner@vger.kernel.org To: Pramod Kumar Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ray Jui , Scott Branden , Russell King , "linux-gpio@vger.kernel.org" , BCM Kernel Feedback , Jason Uy , Masahiro Yamada , Thomas Gleixner , Laurent Pinchart , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Jonas Gorski List-Id: devicetree@vger.kernel.org On Mon, Oct 19, 2015 at 7:43 AM, Pramod Kumar wrote: > Add ngpios property to the gpio controller's DT node so that controller > driver extracts total number of gpio lines present in controller > from DT and removes dependency on driver. > > Signed-off-by: Pramod Kumar > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden (...) > +- ngpios: > + Total number of GPIOs the controller provides This description is wrong. The number of GPIOs the controller *provides* is to be determined by the compatible-string. ngpios is used to restrict the number of lines *used* or *routed* from the number *available*. (I hope that is what the code does as well.) Such as if 12 GPIOs are used of the 32 available on 32bits in a register. Update this description to say what it really means. Yours, Linus Walleij