From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C9CC7618A for ; Sun, 19 Mar 2023 21:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230163AbjCSVEJ (ORCPT ); Sun, 19 Mar 2023 17:04:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbjCSVEI (ORCPT ); Sun, 19 Mar 2023 17:04:08 -0400 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DB5B6A4C for ; Sun, 19 Mar 2023 14:04:04 -0700 (PDT) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-53d277c1834so192142847b3.10 for ; Sun, 19 Mar 2023 14:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679259844; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uHlOtmRhbXRseoAMuvDfv2S+ldzj7KSVKxvkV6Isssc=; b=bruA6+gbtnYJyIR7+WxFwZh5y5zLSPKx/augfql2C6/nmpu7P6VXCh8UcAfqFv/bfn 85Zt6k1m7oTqnT9BnoJnir3on8cb0wciQMS7CU4IXYFMypjpwIDuQIn7krMKKiw6eeH7 0b6u4UbBuOhu0LKA+OpI1AyqhWAhJbgTGnzMykdV5A1WE/k7/BfxoQjlpqSJ5oKCZ2le nxTXbVG6pcKXzqghfgGhgJCkPpSis9kLJxr0x+O22dwmMP/7+y8i1UFdh1LRmuLkBiK4 y10+CdjVj9/R9uetTf2biaAUsmsOSwcE+i8iIsymvaikFVt0oT2qayPe66Da+lSgiCe8 w6gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679259844; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uHlOtmRhbXRseoAMuvDfv2S+ldzj7KSVKxvkV6Isssc=; b=gmfFZFKFIZBDC4dUwQ1tJDuDZ8/2EKq+J18o8B5sgODZ2TIcA5e6ByTwRjov2xOHbQ KXO/gnI+8mjhqF3HwMf0aTEJPLczKaE8n7rvLcA7L7uNcmrsEyHZ3nrBzc/YRqLyYnoS MqRUNVgOLc1ZuUjJkUeF+QMfTxm1D/+BvUfPHE0RwHajY0XB4UTdm27jgFsaH2WoUv/s oOsETt5LFOAKtD6gb7JLFkbMMvUgAGnbYqVCYvQocumHgSY907oAw7GqI7CAAiHJ6jpS e8Idfsy1/uw2p6lT70X6JJY9RJO6A6UHxhJwsveGSBP3sI+sdd1VXH4CqGv+uGUf6LO+ SlLg== X-Gm-Message-State: AO0yUKVtyQKAB49xyb8DlrKmYg+swIEqqMYWMV2ArxlEcMK7wrgGDoKt mEfhzWg6NRQL0LMDREBVAhsqBTsY6q+FXZZWECyOGg== X-Google-Smtp-Source: AK7set/04BNL1IZQ2ZoTv/hKzO515Y7fhbtJesHPiD/G6odhiwBO82T6HTUjnRKfAgbfZp4XgBZ6kJZDWB83+4HIHcg= X-Received: by 2002:a81:e205:0:b0:52a:9f66:80c6 with SMTP id p5-20020a81e205000000b0052a9f6680c6mr8233006ywl.9.1679259843810; Sun, 19 Mar 2023 14:04:03 -0700 (PDT) MIME-Version: 1.0 References: <20230316072940.29137-1-quic_devipriy@quicinc.com> <20230316072940.29137-5-quic_devipriy@quicinc.com> In-Reply-To: From: Linus Walleij Date: Sun, 19 Mar 2023 22:03:52 +0100 Message-ID: Subject: Re: [PATCH V9 4/6] pinctrl: qcom: Add IPQ9574 pinctrl driver To: Devi Priya , Bjorn Andersson Cc: agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, broonie@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_srichara@quicinc.com, quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com, quic_anusha@quicinc.com, quic_poovendh@quicinc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Mar 19, 2023 at 10:02=E2=80=AFPM Linus Walleij wrote: > On Thu, Mar 16, 2023 at 8:31=E2=80=AFAM Devi Priya wrote: > > > Add pinctrl definitions for the TLMM of IPQ9574 > > > > Reviewed-by: Krzysztof Kozlowski > > Co-developed-by: Anusha Rao > > Signed-off-by: Anusha Rao > > Signed-off-by: Devi Priya > > --- > > Changes in V9: > > - Added COMPILE_TEST for non-OF configurations in config PINCTR= L_IPQ9574 > > - Unwrapped the lines for PINGROUP 34 & 62 in ipq9574_groups > > - Removed the comma from terminator line in ipq9574_pinctrl_of_= match[] array > > - Moved the MODULE_DEVICE_TABLE entry just below the array > > ipq9574_pinctrl_of_match[] > > Looks good to me but I would like Bjorns ACK on this patch before I merge= it > if possible. Ah wait I see that bjorn already merged the DTS file so I guess he's fine with the set. Patch applied! Yours, Linus Walleij