From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: "cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org"
<cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>,
Dong Aisheng <dongas86-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"Sascha Hauer (s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org)"
<s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: An extremely simplified pinctrl bindings proposal
Date: Tue, 7 Feb 2012 02:07:14 +0100 [thread overview]
Message-ID: <CACRpkdZVvSOOUvobiiahHdyP8pNcX65QRLeoGALBB6t++Ga5vg@mail.gmail.com> (raw)
In-Reply-To: <20120206235733.GY1426-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
On Tue, Feb 7, 2012 at 12:57 AM, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:
>> I'm not sure if I'm following completely, if this is inside the devicetree-based
>> driver file, would it work to just add a struct dentry * to the
>> pinctrl_desc where you put a per-driver file?
>
> I was thinking generic debufs entries for all drivers.
OK.
>> Or maybe add extern void pinctrl_add_debugfs(struct dentry *) that adds
>> a new file to the existing per-driver directory through the core and then
>> have this add that file?
>
> Sounds like you've thought it further than me already :)
>
> Maybe that's the way to go to solve the one register for
> multiple pins issue.
>
>> Or did you mean that the core.c should be register-aware?
>
> I was just thinking string name ignoring core.c, so that would
> be the pinctrl_add_debugfs() option then. Do you see problems
> with this approach?
No probs, something like that you call any number of times
after registering the core device should work fine I guess.
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-02-07 1:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 5:31 An extremely simplified pinctrl bindings proposal Stephen Warren
2012-02-05 6:07 ` Richard Zhao
2012-02-06 3:07 ` Thomas Abraham
2012-02-06 5:44 ` Stephen Warren
2012-02-06 4:20 ` Linus Walleij
[not found] ` <CACRpkdahin4srDh7dphgvq306gjz7CGP=h4dVkUY+w0z0wpXRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-06 5:53 ` Stephen Warren
2012-02-06 17:29 ` Linus Walleij
[not found] ` <CACRpkdbtTPSoX1x4aBtNVGZ2Qex9t77D09V9JgON_jfShQdx6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-06 19:03 ` Tony Lindgren
[not found] ` <20120206190315.GU1426-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-02-06 19:56 ` Linus Walleij
[not found] ` <CACRpkdZthbejmTqRJAWHb8jU-p8LPT_+zj_CY1q0voMb4FKz2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-06 21:04 ` Tony Lindgren
2012-02-06 23:15 ` Linus Walleij
[not found] ` <CACRpkdYrbD3PpJ3wb69yb3Ya8SeZJnPpgJdtttjWTkS5xsD-4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-06 23:57 ` Tony Lindgren
[not found] ` <20120206235733.GY1426-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-02-07 1:07 ` Linus Walleij [this message]
2012-02-07 5:28 ` Stephen Warren
[not found] ` <4F2F6AE2.1040504-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-02-06 19:41 ` Mark Brown
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF178E5D3160-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-02-06 18:57 ` Tony Lindgren
2012-02-06 19:05 ` Mitch Bradley
2012-02-06 19:26 ` Linus Walleij
[not found] ` <CACRpkdYt-L+an5DTdYkS5Hi+18-rszAt7hXwZNUNVK-d0UaCWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-06 21:24 ` Mitch Bradley
[not found] ` <4F302474.1020701-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2012-02-07 5:33 ` Stephen Warren
[not found] ` <4F30B79C.4030404-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-02-07 7:07 ` Mitch Bradley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZVvSOOUvobiiahHdyP8pNcX65QRLeoGALBB6t++Ga5vg@mail.gmail.com \
--to=linus.walleij-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dongas86-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).