From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35D3C433F5 for ; Mon, 13 Sep 2021 23:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8BA3610FB for ; Mon, 13 Sep 2021 23:00:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350103AbhIMXCG (ORCPT ); Mon, 13 Sep 2021 19:02:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350112AbhIMXCB (ORCPT ); Mon, 13 Sep 2021 19:02:01 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DCACC08EB44 for ; Mon, 13 Sep 2021 15:41:43 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id i25so20360381lfg.6 for ; Mon, 13 Sep 2021 15:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=upRGSvfI0tAPjnVdV7FbBFHnENJLudrtgzcATKEHgT4=; b=h6B7gVAlebvZcb1esp+vXodBjuwKJessM+ghgQHzsD2ni5g1VZIhBt1OuMZdSxFiJT KrcE06Nx4XN6B3hE3DaVjvWQngWHvaeDrVMR/JIdFGDUrJm4iDsrsiCjudkDODl+IMdQ wL0xPxFV8pVGbKQmUGZ0y+TxSddLlmi0VmiMbEOFpsnde5Y/PILjYRzpS8lQKDjXk1ln XKztWgHmLeuhiforjNPCPqP34n2dvpb4gTsJpBthdvpYPmyORkm/9SqXVnqCAZoZxlEe Imxgmf2pxNyKrAC2n7j3AgkieIgK2PiKv8OUYPM1HiDNJ0+WM1e0RHxKerKfc7VYorp2 kDiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=upRGSvfI0tAPjnVdV7FbBFHnENJLudrtgzcATKEHgT4=; b=WR0itDMuMI49wKfp9GHcAwaHS3BdDFfv5m+dr/+DvYXdbQvKa2gSjdGzzdmak2Dq7X IpJeZTxidEJcnWKhbQ66Hg38HEFY6+geBwjTkYAXVQqvvGzpNU3BzhTVfiJgk22AqgOY MTgnJiZYbGpXM9NvVr1YrUIWByxORTFlyM+GjdVBKCE0XJBjzr7L+AnKexIy+oRPVFKq hU2Ec/LTlLwOeK6O9hCJR4U/kGxMKsEVe9MI6SJeHu4EsHxUY1ihwmD45SYXfGsRYdHy b+fIGoUrU8IU6pV+xwkNPDtbFf31iWxh8P4WTYTsEOu9Teqg5fT5evaEjUybV0Nkq8em D2DA== X-Gm-Message-State: AOAM531SVpm4j0VXNfmJEu2+CS7fcoQbJVMRL6QhJZ44INDhndF85oNp xezt/xcSFoyzHkMq1u8+0ONPgeOVEcYlhYfu/Cr8s/GyUQU= X-Google-Smtp-Source: ABdhPJyClz/wdZ2qN3qY1qOBTysf44ukjyOseGX9SIs771urlmNDjXsAudAHpy1eyUkJpyeI9gvh48oOwTuyy7n4LA4= X-Received: by 2002:a05:6512:12c4:: with SMTP id p4mr11067299lfg.72.1631572901904; Mon, 13 Sep 2021 15:41:41 -0700 (PDT) MIME-Version: 1.0 References: <20210913192816.1225025-1-robh@kernel.org> <20210913192816.1225025-2-robh@kernel.org> In-Reply-To: <20210913192816.1225025-2-robh@kernel.org> From: Linus Walleij Date: Tue, 14 Sep 2021 00:41:31 +0200 Message-ID: Subject: Re: [PATCH v2 1/8] dt-bindings: leds: Convert register-bit-led binding to DT schema To: Rob Herring Cc: Stephen Boyd , Pavel Machek , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Linux ARM , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , Linux LED Subsystem Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Sep 13, 2021 at 9:28 PM Rob Herring wrote: > Convert the register-bit-led binding to DT schema format. > > As the example just repeats nearly identical nodes, trim it down to a > few nodes and use some documented values for 'linux,default-trigger'. > > Cc: Linus Walleij > Cc: Pavel Machek > Cc: linux-leds@vger.kernel.org > Signed-off-by: Rob Herring Thanks for doing this! > v2: > - Drop undocumented linux,default-trigger values Will this lead to warnings? People tend to want to use these. (Possibly we could actually create operating-system independent triggers that make sense on any system. But it's another can of worms we don't need to open today.) > + enum: > + [ 0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40, 0x80, 0x100, 0x200, 0x400, 0x800, > + 0x1000, 0x2000, 0x4000, 0x8000, 0x10000, 0x20000, 0x40000, 0x80000, > + 0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000, > + 0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ] That's an interesting looking enum :D But I can't think of anything better, so: Reviewed-by: Linus Walleij Yours, Linus Walleij