From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C480C433E7 for ; Tue, 13 Oct 2020 13:27:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1711822D73 for ; Tue, 13 Oct 2020 13:27:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MwfmDJKm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728614AbgJMN1Z (ORCPT ); Tue, 13 Oct 2020 09:27:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728609AbgJMN1Z (ORCPT ); Tue, 13 Oct 2020 09:27:25 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2156C0613D2 for ; Tue, 13 Oct 2020 06:27:24 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id a5so20412026ljj.11 for ; Tue, 13 Oct 2020 06:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6NIDO88L/SfLo7a2I6RUC0k7nZAbu1A3o1CF53Wby8o=; b=MwfmDJKmJ81pU5hFl/rnyB8ayCOt5/lEUwSU27O6JDx9gQHn3DTxf+20E2rDsHteN3 9JTXgdXXsFRCbcDH9mN59YWJeO5adNlI1tyTLFP3T75BWSlWOBZlXUIezLx4IvooOzhl iGMrxOm/GgqysYdhsEknsvhLgGgOndvkipKdbiQSRDirQWRFH7UT0/jHGov7IYyeLf9J L5CvqhwM4drP3u2Hx5OyA2YyEVgNmqYg3Rmh4z4C97GCr5h0HIZPZWmqSlg4fwlsX8jR QsCFkAfIZTTPlYPiMnrleySRmUurBcPFBXPWPMEkZ88jIn7qIWgNQRBHz0cZXIkUQY3H 7cUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6NIDO88L/SfLo7a2I6RUC0k7nZAbu1A3o1CF53Wby8o=; b=DTPs2DpVpp2T8LkBqVr1HSWCfpNO7Gfv3YYwHsl0lgVXpQVw6gBU2aaIPf8Y1RtgqR 4IY+k9mhESnvC9V8RvLuGY5Qd0dy2a5Tsbe6hGZLV9wN0Ddczx1E0v3wu+kHF0eEO//k nF7khFd+Dr69Ntjyz/o9HzzuW5Ah/AAwrFGR1EWZyErZjzMhfdxH80VcK/TmM97fUD0k xpISA+HkhtAlaOSdNQYjkrlITRA6oE6DUThlER9Li/Tmz8x4FEnE51TvKXInG+XLVUJq 3DsBY41dKsaGTfJ7MwAbHJfn0O/LNV6JZgWr0iBR3HMehqtlqbDNE8zMhBwlyrxfOePt ONIw== X-Gm-Message-State: AOAM530BupJTiUP3E/BaG9PFVSNIAy7g83pBY17U5Aa1fmu3q0RNQpM9 7HCybN00Y9VrGabuXBS1lvIwwwRO6KTCZ5jRg3MViw== X-Google-Smtp-Source: ABdhPJyUtzNpor9sibSYIY37lGowERAa80Msa/zFAJYgm+rvw5o4xkcDDfln7nDCdfKgqesfqrths5OjzjeufIK57F0= X-Received: by 2002:a2e:b893:: with SMTP id r19mr2025007ljp.104.1602595641517; Tue, 13 Oct 2020 06:27:21 -0700 (PDT) MIME-Version: 1.0 References: <20201004162908.3216898-1-martin.blumenstingl@googlemail.com> <20201004162908.3216898-3-martin.blumenstingl@googlemail.com> In-Reply-To: From: Linus Walleij Date: Tue, 13 Oct 2020 15:27:10 +0200 Message-ID: Subject: Re: [RFC PATCH 2/3] dt-bindings: gpio: Add binding documentation for Etron EJ168/EJ188/EJ198 To: Martin Blumenstingl Cc: linux-pci , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Rob Herring , Bartosz Golaszewski , "linux-kernel@vger.kernel.org" , Bjorn Helgaas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Oct 7, 2020 at 9:58 PM Martin Blumenstingl wrote: > On Wed, Oct 7, 2020 at 11:19 AM Linus Walleij wrote: > > On Sun, Oct 4, 2020 at 8:00 PM Martin Blumenstingl > > wrote: > > > > > +properties: > > > + compatible: > > > + enum: > > > + - pci1b6f,7023 > > > + - pci1b6f,7052 > > > > I think it is better to let the PCI driver for the whole hardware in > > drivers/usb/host/xhci-pci.c probe from the PCI configuration space > > numbers, and then add a gpio_chip to xhci-pci.c. > > to have everything consistent I will move the binding to > Documentation/devicetree/bindings/usb I do not understand why a PCI device would need a DT binding at all. They just probe from the magic number in the PCI config space, they spawn struct pci_dev PCI devices, not the type of platform devices coming out of the DT parser code. No DT compatible needed. What am I not understanding about this? Yours, Linus Walleij