From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH anybus v2 1/5] misc: support the Arcx anybus bridge. Date: Thu, 1 Nov 2018 22:53:46 +0100 Message-ID: References: <20181031194425.32132-1-TheSven73@googlemail.com> <20181031194425.32132-2-TheSven73@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sven Van Asbroeck Cc: Arnd Bergmann , svendev@arcx.com, Lee Jones , Rob Herring , Mark Rutland , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Thierry Reding , David Lechner , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Johan Hovold , Michal Simek , michal.vokac@ysoft.com, Greg KH , john.garry@huawei.com, Geert Uytterhoeven , Robin Murphy , Paul Gortmaker , Sebastien Bourdelin , Icenowy Zheng , Stuart Yoder , Maxime List-Id: devicetree@vger.kernel.org On Thu, Nov 1, 2018 at 6:17 PM Sven Van Asbroeck wrote: > >> +static DEVICE_ATTR_RO(version); > > > > Do you need this in userspace really? > > > >> +static DEVICE_ATTR_RO(design_number); > > > > And this? > > Unfortunately, I do :( > The application software reads these out and displays them in an UI. It's > important to be able to see these on a running device. OK... > Perhaps there is another kernel abstraction I could use? I don't think so. If you want to be pedantic, document the sysfs files in Documentation/ABI/testing/sysfs-* Maybe the properties should be on the bus though? I don't know :/ Yours, Linus Walleij