From: Linus Walleij <linus.walleij@linaro.org>
To: Tony Prisk <linux@prisktech.co.nz>
Cc: vt8500-wm8505-linux-kernel@googlegroup.com,
Russell King <linux@arm.linux.org.uk>,
Alessandro Zummo <a.zummo@towertech.it>,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
Arnd Bergmann <arnd@arndb.de>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Linus Walleij <linus.walleij@stericsson.com>,
Mike Turquette <mturquette@ti.com>,
Stephen Warren <swarren@nvidia.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [rtc-linux] [PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500
Date: Wed, 22 Aug 2012 11:21:32 +0200 [thread overview]
Message-ID: <CACRpkdZnQyLSRQ6cRpFBurAv2cv44einGAsT86FLCqsj1euDMA@mail.gmail.com> (raw)
In-Reply-To: <1345582058-2291-9-git-send-email-linux@prisktech.co.nz>
On Tue, Aug 21, 2012 at 10:47 PM, Tony Prisk <linux@prisktech.co.nz> wrote:
> Converted the existing arch-vt8500 gpio to a platform_device.
> Added support for WM8505 and WM8650 GPIO controllers.
(...)
> + unsigned val;
I asked about the datatype for this "val", it sure isn't "unsigned".
I suspected the registers were only 8bit and so it should be u8.
But atleast use u32 if you must use all these bits.
(...)
> + val = readl(vt8500_chip->base + vt8500_chip->regs->en);
> + val |= BIT(offset);
> + writel(val, vt8500_chip->base + vt8500_chip->regs->en);
BTW: have you considered [readl|writel]_relaxed?
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-08-22 9:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 20:47 [PATCHv3 0/9] *** ARM: Update arch-vt8500 to Devicetree *** Tony Prisk
2012-08-21 20:47 ` [PATCHv3 1/9] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's Tony Prisk
2012-08-21 20:47 ` [PATCHv3 2/9] rtc: vt8500: Add devicetree support for vt8500-rtc Tony Prisk
[not found] ` <1345582058-2291-1-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2012-08-21 20:47 ` [PATCHv3 3/9] serial: vt8500: Add devicetree support for vt8500-serial Tony Prisk
2012-08-21 22:12 ` Alan Cox
[not found] ` <20120821231255.71a7515a-38n7/U1jhRXW96NNrWNlrekiAK3p4hvP@public.gmane.org>
2012-08-22 6:34 ` [PATCHv3 3/9] serial: vt8500: Add devicetree support for Tony Prisk
2012-08-22 6:44 ` Arnd Bergmann
2012-08-23 21:29 ` Rob Landley
2012-08-21 20:47 ` [PATCHv3 4/9] usb: vt8500: Add devicetree support for vt8500-ehci and -uhci Tony Prisk
2012-08-21 20:47 ` [PATCHv3 5/9] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb Tony Prisk
2012-08-21 20:47 ` [PATCHv3 6/9] arm: vt8500: Update arch-vt8500 to devicetree support Tony Prisk
2012-08-21 20:47 ` [PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500 Tony Prisk
2012-08-22 9:21 ` Linus Walleij [this message]
2012-08-22 13:33 ` [rtc-linux] " Tony Prisk
2012-08-21 20:47 ` [PATCHv3 9/9] arm: vt8500: clk: Add Common Clock Framework support Tony Prisk
2012-08-21 20:47 ` [PATCHv3 7/9] arm: vt8500: doc: Add device tree bindings for arch-vt8500 devices Tony Prisk
[not found] ` <1345582058-2291-8-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2012-08-22 21:07 ` Stephen Warren
2012-08-22 21:32 ` Tony Prisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZnQyLSRQ6cRpFBurAv2cv44einGAsT86FLCqsj1euDMA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=FlorianSchandinat@gmx.de \
--cc=a.zummo@towertech.it \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@prisktech.co.nz \
--cc=mturquette@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@nvidia.com \
--cc=vt8500-wm8505-linux-kernel@googlegroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).