From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [rtc-linux] [PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500 Date: Wed, 22 Aug 2012 11:21:32 +0200 Message-ID: References: <1345582058-2291-1-git-send-email-linux@prisktech.co.nz> <1345582058-2291-9-git-send-email-linux@prisktech.co.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1345582058-2291-9-git-send-email-linux@prisktech.co.nz> Sender: linux-serial-owner@vger.kernel.org To: Tony Prisk Cc: vt8500-wm8505-linux-kernel@googlegroup.com, Russell King , Alessandro Zummo , Alan Cox , Greg Kroah-Hartman , Florian Tobias Schandinat , Arnd Bergmann , Grant Likely , Rob Herring , Rob Landley , Linus Walleij , Mike Turquette , Stephen Warren , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Tue, Aug 21, 2012 at 10:47 PM, Tony Prisk wrote: > Converted the existing arch-vt8500 gpio to a platform_device. > Added support for WM8505 and WM8650 GPIO controllers. (...) > + unsigned val; I asked about the datatype for this "val", it sure isn't "unsigned". I suspected the registers were only 8bit and so it should be u8. But atleast use u32 if you must use all these bits. (...) > + val = readl(vt8500_chip->base + vt8500_chip->regs->en); > + val |= BIT(offset); > + writel(val, vt8500_chip->base + vt8500_chip->regs->en); BTW: have you considered [readl|writel]_relaxed? Yours, Linus Walleij