From: Linus Walleij <linus.walleij@linaro.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: "Drew Fustini" <drew@beagleboard.org>,
"Grygorii Strashko" <grygorii.strashko@ti.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jason Kridner" <jkridner@beagleboard.org>,
"Robert Nelson" <robertcnelson@beagleboard.org>
Subject: Re: [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names
Date: Mon, 18 May 2020 10:41:27 +0200 [thread overview]
Message-ID: <CACRpkdZnnRXwv0-71t93HX42jL-muty4yJx5gW6_P3yOM-sGAg@mail.gmail.com> (raw)
In-Reply-To: <875zcty7tt.fsf@kernel.org>
On Mon, May 18, 2020 at 10:18 AM Felipe Balbi <balbi@kernel.org> wrote:
> Linus Walleij <linus.walleij@linaro.org> writes:
> >> gpiochip0 - 32 lines:
> >> line 0: "ethernet" unused input active-high
> >> line 1: "ethernet" unused input active-high
> >
> > Why are the ethernet lines not tagged with respective signal name
> > when right below the SPI lines are explicitly tagged with
> > sclk, cs0 etc?
> >
> > Ethernet is usually RGMII and has signal names like
> > tx_clk, tx_d0, tx_en etc.
> >
> > Also some lines seem to be tagged with the pin number
> > like P9_22, P2_21 below, it seems a bit inconsistent
> > to have much information on some pins and very sketchy
> > information on some.
>
> the pin names match the beagle bone documentation and would help users
> figure out which pins on the expansion headers match to a gpio signal.
OK if it is how it looks in the documentation I agree that is what
users need, maybe the documentation is confusing but there is not
much to do about that.
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-05-18 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 16:58 [PATCH] arm: dts: am33xx-bone-common: add gpio-line-names Drew Fustini
2020-05-12 13:52 ` Tony Lindgren
2020-05-18 7:11 ` Linus Walleij
2020-05-18 8:18 ` Felipe Balbi
2020-05-18 8:41 ` Linus Walleij [this message]
2020-05-18 12:34 ` Felipe Balbi
2020-05-18 14:24 ` Drew Fustini
2020-05-18 14:18 ` Drew Fustini
2020-05-20 22:02 ` Drew Fustini
2020-05-25 9:23 ` Linus Walleij
2020-05-25 12:07 ` Drew Fustini
2020-05-25 13:03 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZnnRXwv0-71t93HX42jL-muty4yJx5gW6_P3yOM-sGAg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=balbi@kernel.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=grygorii.strashko@ti.com \
--cc=jkridner@beagleboard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@beagleboard.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).