From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 2/3] gpiolib: gpiod_hog remove separate name argument Date: Mon, 21 Sep 2015 16:28:48 -0700 Message-ID: References: <1440920686-6892-1-git-send-email-mpa@pengutronix.de> <1440920686-6892-3-git-send-email-mpa@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1440920686-6892-3-git-send-email-mpa@pengutronix.de> Sender: linux-gpio-owner@vger.kernel.org To: Markus Pargmann Cc: Alexandre Courbot , Arun Bharadwaj , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Johan Hovold , chrisrfq@gmail.com, "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Sascha Hauer List-Id: devicetree@vger.kernel.org On Sun, Aug 30, 2015 at 12:44 AM, Markus Pargmann wrote: > The gpio name is now stored in the gpio descriptor, so we can simply use > that instead of an argument to the function. > > Signed-off-by: Markus Pargmann Several problems with this patch: - Does not apply to v4.3-rc1 - Fixed that but noted that it just alters the call to gpiod_hog() in of_gpiochip_scan_hogs(), there is a local const char *name that should be removed too. - Looking at of_get_gpio_hog() it is unclear to me that .name is set in the gpio_desc as desired. Please check this. Crucial code looks like this: if (name && of_property_read_string(np, "line-name", name)) *name = np->name; i.e. is the line-name really propagated to gpiod->name? Are you sure you have tested this with a DTS using line-name and verified that it propagates properly? Yours, Linus Walleij