devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] mfd: db8500-prcmu: Fetch the PRCMU TCDM base address from Device Tree
Date: Tue, 26 Mar 2013 10:11:13 +0100	[thread overview]
Message-ID: <CACRpkdZxU197moM_00UQr-tHdip4b50c+CfYkR5OK+MbwsE-aw@mail.gmail.com> (raw)
In-Reply-To: <20130326081704.GB11734-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tue, Mar 26, 2013 at 9:17 AM, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On Mon, 25 Mar 2013, Linus Walleij wrote:
>> On Mon, Mar 25, 2013 at 5:46 PM, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>>
>> >> >         res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>> >> >                                            "prcmu-tcpm");
>> >> >         if (!res) {
>> >> > -               dev_err(&pdev->dev,
>> >> > -                       "Error: no prcmu tcpm memory region provided\n");
>> >> > -               return;
>> >> > -       }
>> >> > -       tcpm_base = ioremap(res->start, resource_size(res));
>> >> > +               if (np) {
>> >> > +                       tcpm_np = of_find_node_by_name(np->parent,
>> >> > +                                                      "prcmu-tcpm-per4");
>> >> > +                       if (!tcpm_np) {
>> >> > +                               dev_err(&pdev->dev,
>> >> > +                                       "no prcmu tcpm mem region provided\n");
>> >> > +                               return;
>> >> > +                       }
>> >> > +                       tcpm_base = of_iomap(tcpm_np, 0);
>> >> > +               }
>> >> > +       } else
>> >> > +               tcpm_base = ioremap(res->start, resource_size(res));
>> >> > +
>> >>
>> >> Why don't you just add these extra registers to the prcmu node itself like
>> >>
>> >> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
>> >> index 9de9309..6ee6c31 100644
>> >> --- a/arch/arm/boot/dts/dbx5x0.dtsi
>> >> +++ b/arch/arm/boot/dts/dbx5x0.dtsi
>> >> @@ -191,8 +191,8 @@
>> >>
>> >>               prcmu: prcmu@80157000 {
>> >>                       compatible = "stericsson,db8500-prcmu";
>> >> -                     reg = <0x80157000 0x1000>;
>> >> -                     reg-names = "prcmu";
>> >> +                     reg = <0x80157000 0x1000>, <0x801b0000 0x1000>, <0x801b8000 0x1000>;
>> >> +                     reg-names = "prcmu", "prcmu-tcpm", "prcmu-tcdm-per4";
>> >>                       interrupts = <0 47 0x4>;
>> >>                       #address-cells = <1>;
>> >>                       #size-cells = <1>;
>> >>
>> >>
>> >> and document those in the prcmu binding?
>> >>
>> >> That would keep the code simpler and the same for both cases.
>> >
>> > I'm not sure you can. These addresses differ from platform to
>> > platform, so I'd need to provide the base PRCMU address in
>> > dbx5x0.dtsi, then the other two in the dts files. Can you do that?
>>
>> Better ask on devicetree-discuss.
>>
>> What it reflects are differences between SoC:s, so I think the
>> right solution is to split it in a three-layer cake:
>>
>> dbx5x0.dtsi -> included by
>> db8500.dtsi -> included by
>> snowball/hrefv60plus.dts
>>
>> dbx5x0.dtsi -> included by
>> dbx540.dtsi -> included by
>> ccu9540/ccu8540.dts
>>
>> Here you may insert the reg property into the node at the
>> db8500.dtsi or dbx540.dtsi layer.
>
> It's easy done, if that's the right way.
>
>> If you prefer I can cook a patch...
>
> ... and I'm fine to do it.
>
> [5 mins later]
>
> Hmm... it appears that in STE's kernel, the same address is used for
> all SoCs:
>
>   #define U8500_PRCMU_TCDM_BASE    (U8500_PER4_BASE + 0x68000)

Yes that's correct...

> However, in Mainline there is another definition:
>
>   #define U9540_PRCMU_TCDM_BASE    (U8500_PER4_BASE + 0x6A000)
>
> ... which doesn't seem to be in use anywhere - even for the u9540.
>
> What's the deal big-man?

Probably there was another address at some point in some FPGA or
early silicon and it now needs fixing.

So you should be able to use the same thing on all ASICs, put one
single value in the dbx5x0.dtsi *and* fix this bug at the same time,
good!

Yours,
Linus Walleij

  parent reply	other threads:[~2013-03-26  9:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1364223758-17621-1-git-send-email-lee.jones@linaro.org>
     [not found] ` <1364223758-17621-2-git-send-email-lee.jones@linaro.org>
     [not found]   ` <201303251540.51104.arnd@arndb.de>
     [not found]     ` <20130325164600.GA11734@gmail.com>
2013-03-25 21:32       ` [PATCH 2/3] mfd: db8500-prcmu: Fetch the PRCMU TCDM base address from Device Tree Linus Walleij
2013-03-26  8:17         ` Lee Jones
     [not found]           ` <20130326081704.GB11734-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-26  9:11             ` Linus Walleij [this message]
     [not found]               ` <20130326094848.GA14151@gmail.com>
2013-03-26 10:00                 ` Arnd Bergmann
2013-03-26 10:19                   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZxU197moM_00UQr-tHdip4b50c+CfYkR5OK+MbwsE-aw@mail.gmail.com \
    --to=linus.walleij-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).