From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH V4 03/18] gpio: tegra: use resume_noirq for tegra gpio resume Date: Tue, 25 Jun 2019 15:38:29 +0200 Message-ID: References: <1561345379-2429-1-git-send-email-skomatineni@nvidia.com> <1561345379-2429-4-git-send-email-skomatineni@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1561345379-2429-4-git-send-email-skomatineni@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: Sowjanya Komatineni Cc: "thierry.reding@gmail.com" , Jon Hunter , Thomas Gleixner , Jason Cooper , Marc Zyngier , Stefan Agner , Mark Rutland , Peter De Schrijver , Prashant Gaikwad , Stephen Boyd , linux-clk , "open list:GPIO SUBSYSTEM" , jckuo@nvidia.com, Joseph Lo , talho@nvidia.com, linux-tegra@vger.kernel.org, "linux-kernel@vger.kernel.org" , Mikko Perttunen , spatra@nvidia.com, Rob Herring , Dmitry Osipenko List-Id: devicetree@vger.kernel.org On Mon, Jun 24, 2019 at 5:03 AM Sowjanya Komatineni wrote: > During SC7 resume, PARKED bit clear from the pinmux registers may > cause a glitch on the GPIO lines. > > So, Tegra GPIOs restore should happen prior to restoring Tegra pinmux > to keep the GPIO lines in a known good state prior to clearing PARKED > bit. > > This patch has fix for this by moving Tegra GPIOs restore to happen > very early than pinctrl resume. > > Signed-off-by: Sowjanya Komatineni Can this patch be applied in isolation from the other patches? WOuld be nice to have at least Thierry's ACK on it before I apply it. Yours, Linus Walleij