From: Linus Walleij <linus.walleij@linaro.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
patches@opensource.cirrus.com
Subject: Re: [PATCH 1/2] mfd: arizona: Update reset pin to use GPIOD
Date: Thu, 22 Feb 2018 15:46:55 +0100 [thread overview]
Message-ID: <CACRpkda3Tc0U_UJAyu-Jhja3E8xg2FRcswcxe2hMofrrXLTAEQ@mail.gmail.com> (raw)
In-Reply-To: <20180214155512.17218-1-ckeepax@opensource.cirrus.com>
On Wed, Feb 14, 2018 at 4:55 PM, Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
> Now GPIOD has support for both pdata systems and for non-standard DT
> bindings the Arizona reset GPIO can be converted to use it.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
(...)
> + pdata->reset = devm_gpiod_get_from_of_node(arizona->dev,
> + arizona->dev->of_node,
> + "wlf,reset", 0,
> + GPIOD_OUT_LOW,
> + "arizona /RESET");
It seems this call is really useful.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Also thanks for testing this API, I had nothing to test it on...
Yours,
Linus Walleij
prev parent reply other threads:[~2018-02-22 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 15:55 [PATCH 1/2] mfd: arizona: Update reset pin to use GPIOD Charles Keepax
2018-02-14 15:55 ` [PATCH 2/2] mfd: arizona: Update DT doc to support more standard reset binding Charles Keepax
2018-02-19 3:13 ` Rob Herring
2018-02-19 10:28 ` Charles Keepax
[not found] ` <20180214155512.17218-1-ckeepax-yzvPICuk2AA4QjBA90+/kJqQE7yCjDx5@public.gmane.org>
2018-02-14 16:05 ` [PATCH 1/2] mfd: arizona: Update reset pin to use GPIOD Charles Keepax
2018-02-22 14:46 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda3Tc0U_UJAyu-Jhja3E8xg2FRcswcxe2hMofrrXLTAEQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).