From: Linus Walleij <linus.walleij@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: vincent.whitchurch@axis.com,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rabin Vincent <rabinv@axis.com>
Subject: Re: [PATCH 1/2] gpio: mockup: Allow probing from device tree
Date: Mon, 10 Sep 2018 09:05:50 +0200 [thread overview]
Message-ID: <CACRpkda3seU8adWOT6FR=JUgzrSYnOwynoe2sSFJ-ysf8cwwBQ@mail.gmail.com> (raw)
In-Reply-To: <CAMRc=Mce5hRtD5kydWjiHSv0-po7PcHmK6AtCTzgvqaPYjP-Jw@mail.gmail.com>
On Thu, Sep 6, 2018 at 6:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> 2018-09-05 15:26 GMT+02:00 Vincent Whitchurch <vincent.whitchurch@axis.com>:
> > + ret = of_property_read_u32(node, "nr-gpios", &nr_gpios);
>
> In addition to what Linus already said: I think this is a good moment
> to get rid of the platform data structure and instead use device
> properties, what do you think?
If you're thinking of fwnode that will not work with static platform devices
(such as add with board files or other random platform_device_register() etc)
The fwnode concept only works with DT and ACPI.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-09-10 11:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 13:26 [PATCH 1/2] gpio: mockup: Allow probing from device tree Vincent Whitchurch
2018-09-05 13:26 ` [PATCH 2/2] dt-bindings: gpio: Add binding for gpio-mockup Vincent Whitchurch
2018-09-06 10:16 ` Linus Walleij
2018-09-06 11:09 ` Bartosz Golaszewski
2018-09-06 12:47 ` Linus Walleij
2018-09-16 23:24 ` Rob Herring
2018-09-18 11:25 ` Vincent Whitchurch
2018-09-24 20:39 ` Rob Herring
2018-09-06 10:25 ` [PATCH 1/2] gpio: mockup: Allow probing from device tree Linus Walleij
2018-09-06 16:29 ` Bartosz Golaszewski
2018-09-10 7:05 ` Linus Walleij [this message]
2018-09-20 16:28 ` Bartosz Golaszewski
2018-09-21 15:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkda3seU8adWOT6FR=JUgzrSYnOwynoe2sSFJ-ysf8cwwBQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=rabinv@axis.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).