From: Linus Walleij <linus.walleij@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: describe sa8775p-tlmm
Date: Wed, 1 Feb 2023 23:45:25 +0100 [thread overview]
Message-ID: <CACRpkdaFCG+PHXrOTGW4ZLMSOcJvJ6eYKRO-VLds1J13OuTYJA@mail.gmail.com> (raw)
In-Reply-To: <CAMRc=Mc8gFpcB6k-qVmSAM0=iKHGBmGcqm3aV2xiyjWPG1wtvg@mail.gmail.com>
On Wed, Feb 1, 2023 at 4:15 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Wed, Feb 1, 2023 at 4:13 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 01/02/2023 16:00, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Add DT bindings for the TLMM controller on sa8775p platforms.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> >
> > > +
> > > +examples:
> > > + - |
> > > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > > +
> > > + tlmm: pinctrl@f000000 {
> > > + compatible = "qcom,sa8775p-tlmm";
> > > + reg = <0xf000000 0x1000000>;
> > > + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> > > + gpio-controller;
> > > + #gpio-cells = <2>;
> > > + interrupt-controller;
> > > + #interrupt-cells = <2>;
> > > + gpio-ranges = <&tlmm 0 0 149>;
> >
> > You have 148 GPIOs, so s/149/148/.
> >
> > I'll fix other bindings as we have such mistake in several places.
> >
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > Best regards,
> > Krzysztof
> >
>
> Ah, cr*p, sorry for missing it. Linus - can you change it when
> applying? I don't want to send more noise.
Of course :)
Yours,
Linus Walleij
next prev parent reply other threads:[~2023-02-01 22:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:00 [PATCH v3 0/2] pinctrl: qcom: add dt-bindings and driver for sa8775p-tlmm Bartosz Golaszewski
2023-02-01 15:00 ` [PATCH v3 1/2] dt-bindings: pinctrl: describe sa8775p-tlmm Bartosz Golaszewski
2023-02-01 15:13 ` Krzysztof Kozlowski
2023-02-01 15:15 ` Bartosz Golaszewski
2023-02-01 22:45 ` Linus Walleij [this message]
2023-02-01 15:00 ` [PATCH v3 2/2] pinctrl: qcom: add the tlmm driver sa8775p platforms Bartosz Golaszewski
2023-02-01 22:46 ` [PATCH v3 0/2] pinctrl: qcom: add dt-bindings and driver for sa8775p-tlmm Linus Walleij
2023-02-02 8:25 ` Bartosz Golaszewski
2023-02-02 12:54 ` Linus Walleij
2023-02-02 13:47 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaFCG+PHXrOTGW4ZLMSOcJvJ6eYKRO-VLds1J13OuTYJA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).