From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B266CC636D3 for ; Wed, 1 Feb 2023 22:45:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbjBAWpm (ORCPT ); Wed, 1 Feb 2023 17:45:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjBAWpl (ORCPT ); Wed, 1 Feb 2023 17:45:41 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2C4D38E94 for ; Wed, 1 Feb 2023 14:45:39 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id y1so177440wru.2 for ; Wed, 01 Feb 2023 14:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nXEg1M/8Ow65IihrBRBuML6WIDNs1pKYceWi+8rT6PE=; b=qDInqtYujTo0IpmxoSiaW8ivIhtbPTHMjMQHFiUTrkQJvgGDw9nyD3Kvuo1p2aAXaR e2w7d8JHOyE8bqtRS7gRpkbGqTjvKH88ZtyVyphv4L8n7ny0pv1XqJyXEei1fMC6a4EM O3kviYo3Jo21H1r+SIBXtcTPlIMHRFJ/dD9i/3M/JRgIHDixrcq9AMHqLaNiHajgFMBP iQYuroK/pZ+Wm0PP+imuHPHBz97BJ2Z7S9YOJ4bsEN1uT5jA6jB6dUpL6XJ8c3F45G0f clmso6BDaXyj3hZjs4MfWBWRbbEahUE27DrL/wLlV+0sSoGifGUkkt54oxqwCiblSdVL yipA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nXEg1M/8Ow65IihrBRBuML6WIDNs1pKYceWi+8rT6PE=; b=p6y8QVsBhIlDpDMIFFyubkGdB5MhPPxD/wpxQAG2a6hAIiMXWAlOQI9xMSW68zzJPU 0tYRyFNewXc9kQxCgz4pdDpjMS38CLj+Uu2io912dkcvUqZXUpWSoc/K43+XoVrWWMyU ubRbIl2ltq+pqVSnphJsYMF3BMxQhobsMGDoohxJM6W8iOPMmAL2aNlTnFiy3+JAtfWO EwCdgEnGHYrGOzMjE2O0wCvf2Ro+NIsPOHWA4c+H2+H3j1kECQDRMU61sJy4CW2i2rVc CT3l61OtjkUpCSdzvbCFt6Mp4Fnz7zBjey6JhR+R0kApGLaL1Eus4SHRdnFLZQpMiT+v x0+Q== X-Gm-Message-State: AO0yUKWEGLe+82FK2uedlHHzliHEA/W3XOJkA6THxC+fd+IqBIkZD/KW 5Knvk/HRAZnKpH2tLDXsI/0xrTNILn6lPN0kkE3l3A== X-Google-Smtp-Source: AK7set8hlhnmbtZBx98H8ICP56Fc5lHNYHDcGn2ClEg32Z21/F1mXiNlNLipP7v0YtJ/2DJTGfai3wxLoTqjPnVhszE= X-Received: by 2002:adf:f94e:0:b0:2bf:edb9:78e5 with SMTP id q14-20020adff94e000000b002bfedb978e5mr127102wrr.383.1675291538313; Wed, 01 Feb 2023 14:45:38 -0800 (PST) MIME-Version: 1.0 References: <20230201150011.200613-1-brgl@bgdev.pl> <20230201150011.200613-2-brgl@bgdev.pl> In-Reply-To: From: Linus Walleij Date: Wed, 1 Feb 2023 23:45:25 +0100 Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: describe sa8775p-tlmm To: Bartosz Golaszewski Cc: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Feb 1, 2023 at 4:15 PM Bartosz Golaszewski wrote: > On Wed, Feb 1, 2023 at 4:13 PM Krzysztof Kozlowski > wrote: > > > > On 01/02/2023 16:00, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Add DT bindings for the TLMM controller on sa8775p platforms. > > > > > > Signed-off-by: Bartosz Golaszewski > > > > > > > + > > > +examples: > > > + - | > > > + #include > > > + > > > + tlmm: pinctrl@f000000 { > > > + compatible = "qcom,sa8775p-tlmm"; > > > + reg = <0xf000000 0x1000000>; > > > + interrupts = ; > > > + gpio-controller; > > > + #gpio-cells = <2>; > > > + interrupt-controller; > > > + #interrupt-cells = <2>; > > > + gpio-ranges = <&tlmm 0 0 149>; > > > > You have 148 GPIOs, so s/149/148/. > > > > I'll fix other bindings as we have such mistake in several places. > > > > > > Reviewed-by: Krzysztof Kozlowski > > > > Best regards, > > Krzysztof > > > > Ah, cr*p, sorry for missing it. Linus - can you change it when > applying? I don't want to send more noise. Of course :) Yours, Linus Walleij