From: Linus Walleij <linus.walleij@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: "Jan Kundrát" <jan.kundrat@cesnet.cz>,
"Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: triggers: gpio: Rewrite to use trigger-sources
Date: Fri, 15 Sep 2023 20:14:19 +0200 [thread overview]
Message-ID: <CACRpkdaG2oGGDjLGWgdi7Y-QS_1Odj7cbbuDiBX8DdNx7agOiw@mail.gmail.com> (raw)
In-Reply-To: <20230915141549.GA3658872-robh@kernel.org>
On Fri, Sep 15, 2023 at 4:15 PM Rob Herring <robh@kernel.org> wrote:
> > + /*
> > + * The generic property "trigger-sources" is followed,
> > + * and we hope that this is a GPIO.
> > + */
> > + gpio_data->gpiod = fwnode_gpiod_get_index(dev->fwnode,
> > + "trigger-sources",
> > + 0, GPIOD_IN,
> > + "led-trigger");
>
> Isn't this going to look for "trigger-sources-gpio" and
> ""trigger-sources-gpios"?
Indeed. I'll simply code an exception for this into
gpiolib-of.c, it's an OF pecularity after all.
Yours,
Linus Walleij
prev parent reply other threads:[~2023-09-15 18:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 13:44 [PATCH 0/2] Rewrite GPIO LED trigger to use trigger-sources Linus Walleij
2023-09-12 13:44 ` [PATCH 1/2] dt-bindings: leds: Mention GPIO triggers Linus Walleij
2023-09-12 17:11 ` Conor Dooley
2023-09-13 13:34 ` Rob Herring
2023-09-14 8:40 ` Linus Walleij
2023-09-14 14:27 ` Rob Herring
2023-09-15 12:01 ` Linus Walleij
2023-09-15 14:10 ` Rob Herring
2023-09-12 13:44 ` [PATCH 2/2] leds: triggers: gpio: Rewrite to use trigger-sources Linus Walleij
2023-09-14 9:10 ` Dan Carpenter
2023-09-15 14:15 ` Rob Herring
2023-09-15 18:14 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaG2oGGDjLGWgdi7Y-QS_1Odj7cbbuDiBX8DdNx7agOiw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jan.kundrat@cesnet.cz \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).