From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v4 04/14] GPIO: Add gpio-ingenic driver Date: Fri, 7 Apr 2017 11:34:38 +0200 Message-ID: References: <20170125185207.23902-2-paul@crapouillou.net> <20170402204244.14216-1-paul@crapouillou.net> <20170402204244.14216-5-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20170402204244.14216-5-paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Cercueil Cc: Alexandre Courbot , Rob Herring , Mark Rutland , Ralf Baechle , Boris Brezillon , Thierry Reding , Bartlomiej Zolnierkiewicz , Maarten ter Huurne , Lars-Peter Clausen , Paul Burton , James Hogan , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux MIPS , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
  • List-Id: devicetree@vger.kernel.org On Sun, Apr 2, 2017 at 10:42 PM, Paul Cercueil wrote: > This driver handles the GPIOs of all the Ingenic JZ47xx SoCs > currently supported by the upsteam Linux kernel. > > Signed-off-by: Paul Cercueil I guess you saw the Kconfig complaint from the build robot, please fix that so we get silent builds. > v2: Consider it's a new patch. Completely rewritten from v1. > v3: Add missing include and drop semicolon after } > v4: Completely rewritten from v3. I really like v4 :) > +static inline bool gpio_get_value(struct ingenic_gpio_chip *jzgc, u8 offset) Actually the return value should be an int. I know, it is a historical artifact, if we change it we need to change it everywhere. > + /* DO NOT EXPAND THIS: FOR BACKWARD GPIO NUMBERSPACE COMPATIBIBILITY > + * ONLY: WORK TO TRANSITION CONSUMERS TO USE THE GPIO DESCRIPTOR API IN > + * INSTEAD. > + */ > + jzgc->gc.base = cell->id * 32; OK then :) This is merge material. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html