From: Linus Walleij <linus.walleij@linaro.org>
To: Lars Povlsen <lars.povlsen@microchip.com>
Cc: Device Tree <devicetree@vger.kernel.org>,
Gregory Clement <gregory.clement@bootlin.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2] mips: gpio: mscc_sgpio: Add DT bindings documentation
Date: Sun, 30 Dec 2018 21:00:10 +0100 [thread overview]
Message-ID: <CACRpkdaW5g2NpknVRz84oS-FWt-0vxKGsbaLv32aKmZtcfHjFg@mail.gmail.com> (raw)
In-Reply-To: <87zhsr2jxk.fsf@soft-dev15.microsemi.net>
On Thu, Dec 27, 2018 at 2:12 PM Lars Povlsen <lars.povlsen@microchip.com> wrote:
> mips: mscc_sgpio: Add DT bindings documentation
>
> This add device tree binding documentation for the MSCC serial GPIO
> driver.
>
> v2 changes:
> - Added more device background info
> - Dropped "mscc,sgpio-bitcount" in favour of "ngpios" and "gpio-ranges".
> - Elaborated "mscc,sgpio-ports" explanation
>
>
> Signed-off-by: Lars Povlsen <lars.povlsen@microsemi.com>
Overall looks good to me!
Acked-by: Linus Walleij <linus.walleij@linaro.org>
> +Optional properties:
> +- ngpios: Set the number of GPIO's actually used.
Just say see: gpio.txt
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-12-30 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 12:06 [PATCH] mips: gpio: mscc_sgpio: Add DT bindings documentation Lars Povlsen
2018-12-07 9:43 ` Linus Walleij
2018-12-07 13:54 ` Rob Herring
2018-12-27 10:18 ` Lars.Povlsen
2018-12-27 13:11 ` [PATCH v2] " Lars Povlsen
2018-12-30 20:00 ` Linus Walleij [this message]
2019-01-02 7:44 ` Lars.Povlsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaW5g2NpknVRz84oS-FWt-0vxKGsbaLv32aKmZtcfHjFg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=lars.povlsen@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).